From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6JWxFkKtA2I8MQEAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 13:02:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6JICFEKtA2LPCwAA9RJhRA (envelope-from ) for ; Wed, 09 Feb 2022 13:02:10 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D48B116AF for ; Wed, 9 Feb 2022 13:02:08 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E097E5F715; Wed, 9 Feb 2022 12:02:05 +0000 (UTC) X-Greylist: delayed 565 seconds by postgrey-1.36 at yantan; Wed, 09 Feb 2022 12:02:03 UTC Received: from mailproxy07.manitu.net (mailproxy07.manitu.net [IPv6:2a00:1828:1000:1112::2]) by mail.notmuchmail.org (Postfix) with ESMTPS id 850C65F711 for ; Wed, 9 Feb 2022 12:02:03 +0000 (UTC) Received: from localhost (200116b8604631004d94416580d017f7.dip.versatel-1u1.de [IPv6:2001:16b8:6046:3100:4d94:4165:80d0:17f7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: michael@grubix.eu) by mailproxy07.manitu.net (Postfix) with ESMTPSA id 4A6F9C889B; Wed, 9 Feb 2022 12:52:40 +0100 (CET) From: Michael J Gruber To: notmuch@notmuchmail.org Subject: [PATCH 3/4] test: reword T380.2 to be clearer Date: Wed, 9 Feb 2022 12:52:35 +0100 Message-Id: <243937764b79b6dce2d66299dd2b11caed258de2.1644406756.git.git@grubix.eu> X-Mailer: git-send-email 2.35.1.306.ga00bde9711 In-Reply-To: References: MIME-Version: 1.0 Message-ID-Hash: XN4OIAJ6SS3QCIPAFZIG5UJIUAVEG35U X-Message-ID-Hash: XN4OIAJ6SS3QCIPAFZIG5UJIUAVEG35U X-MailFrom: git@grubix.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644408128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=lr6otPram9/yGtTeIKrpo2/ZL/7YE3cm41f0nT7gC6Q=; b=YnJ5cCXlXyyulRSSFrHMgTz35XeDV/ZzVsFEIWqw6P1+zELSqbHqlH9pmKLIbvM+4xb+In +sMt+sGKmk5NnN/5KSwkpFRhD/nFqRAiTTl5KDDC+aNcWY8OHkcWOpmUDZLx5K1akd3F1x FZ+obLMQaVLrKF78RAvcptkrXphDVZrebd2MJLMMa/5MxCCZNv610qj+F4MNunx1DisPLl LPmrFpTiDuPux87l4XyLZYBnTYI4CXZUIWyLJiyrMMGO2ClllKDHFY/3jMWZLB+8vFk8vj PwSYyKrY4Zrp2GjDcVnJ3NG5BWq4Pt6Ob6n1EmNk/QUF+cOEmoK7c5jcVcvcGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644408128; a=rsa-sha256; cv=none; b=sdLCIRJlaAykImKBcuhGBapESRmuXYAoXxplS2Hqbczc9mDpFnmqwps1z/U6WJen2nmylc kxxVhqYs2TVdOpllKtDiHKzvIsbMphBy+96nKGTjr8IvL1eh3rN8UMKRaTT42MsKrLqyPy 3TzXb4DPm/Lp3rA5KjA+i2y8A7CDAkgGbM3gJUdo+nYcb6uDu4WWoPpYxWOpT8RgEdSElh 87GzHoy3YxKnHAFLkrVuejDdEFlV2POeIhRROnvCd1ONd9gle750pBjYcHM4YnlbPDPxyd 9YFmgjuI4tbtUzZAegWYpLTHgqbbZN9MWOaGFzaR4XivgSPBM4/PnJwl8ppuHw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.52 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 0D48B116AF X-Spam-Score: -1.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: E1g0wmrYx+Kg T380.2 gives a test description which depends on the actual test output, rather than the expected outcome or actual test which is performed. So, when the test fails due missing abort points, the test describes itself as `detected 0>10 abort points` so that it's not clear which part or which number is the expectation. (Also, `0>10` is no number ...) When the test is not run for some reason and fails because of that, the test describes itself as `detected >10 abort points`, which arguably is better or worse. Reword it to say `detected more than 10 abort points`, which is the actual expectation and what we test for. The failing test line still gives the actual number. Signed-off-by: Michael J Gruber --- test/T380-atomicity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh index 7f618062..49df5c38 100755 --- a/test/T380-atomicity.sh +++ b/test/T380-atomicity.sh @@ -99,7 +99,7 @@ fi test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' test_expect_equal_file expectall searchall -test_begin_subtest "detected $outcount>10 abort points" +test_begin_subtest "detected more than 10 abort points" test_expect_success "test $outcount -gt 10" test_done -- 2.35.1.306.ga00bde9711