unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH 3/4] configure: SC2034: glib_cflags and glib_ldflags appear unused.
Date: Wed, 13 Apr 2016 21:32:48 +0300	[thread overview]
Message-ID: <217817718f4a08799c61b0b2cd8623b3e85949da.1460572142.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1460572142.git.jani@nikula.org>
In-Reply-To: <cover.1460572142.git.jani@nikula.org>

Fix shellcheck warnings.

---

The alternative would be to actually set and and use the results, but
it's a bit redundant as it's all in the gime flags anyway.
---
 configure | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index d4f56b905cce..f3498e3ef244 100755
--- a/configure
+++ b/configure
@@ -413,8 +413,9 @@ have_glib=0
 if pkg-config --exists 'glib-2.0 >= 2.22'; then
     printf "Yes.\n"
     have_glib=1
-    glib_cflags=$(pkg-config --cflags glib-2.0)
-    glib_ldflags=$(pkg-config --libs glib-2.0)
+    # these are included in gmime cflags and ldflags
+    # glib_cflags=$(pkg-config --cflags glib-2.0)
+    # glib_ldflags=$(pkg-config --libs glib-2.0)
 else
     printf "No.\n"
     errors=$((errors + 1))
-- 
2.1.4

  parent reply	other threads:[~2016-04-13 18:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 18:32 [PATCH 0/4] configure: fix some shellcheck warnings Jani Nikula
2016-04-13 18:32 ` [PATCH 1/4] configure: SC2006: Use $(..) instead of deprecated `..` Jani Nikula
2016-04-13 18:32 ` [PATCH 2/4] configure: SC2059: Don't use variables in the printf format string Jani Nikula
2016-04-13 18:32 ` Jani Nikula [this message]
2016-04-13 18:32 ` [PATCH 4/4] configure: SC2016: Expressions don't expand in single quotes Jani Nikula
2016-04-27 18:14 ` [PATCH 0/4] configure: fix some shellcheck warnings Tomi Ollila
2016-05-02  0:25   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=217817718f4a08799c61b0b2cd8623b3e85949da.1460572142.git.jani@nikula.org \
    --to=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).