From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SPCCDY3Iu2TvngAASxT56A (envelope-from ) for ; Sat, 22 Jul 2023 14:16:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wAhSDY3Iu2QaYgEA9RJhRA (envelope-from ) for ; Sat, 22 Jul 2023 14:16:13 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0277D61DED for ; Sat, 22 Jul 2023 14:16:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690028172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=5hqwmZudwQiRx6FkwmjQasAqj/ZaeIHmbQk7/wJZBI4=; b=epUwK976C8y74jRps6ahffJ4mtbaa1UhH7Y2nGSMOAAZ/9gIXfxU/HO+tPOmVWp7mi3AoD 4c4mT60zt/5SHGOY+8W8yDWik8/VkTRmW33a7N1Yc6fmvDxa5Wf7sYoBrUV6pQwxrnkslv h799Y2Fy4j0QDUIBntWo93zEnF1p+m15mP75RlH22dQmpQ3AvgEr7lGAW+Zp7qGtNs5Ard +MbNeotK2/FOVQioh6JnGKs9Ym3MMT369HGZVKUPP1Nln0hCUfk+TnS4BUF+z51Rz9wem+ DXTJsNr9Bnt0+eKfB9KNA9P4BJJrkScHX0zVNMqqUWopvs0cftxeSTHMFhdVPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690028172; a=rsa-sha256; cv=none; b=QmnWVIdfkP58B8z2p4SMp7OKZxfOtaivjqe98ZvJVt3RzfR5r91qpsQgxjvngI3d8RbhYZ 5M5mQKjeeB2HxNjouCg7JNpjJcaOHH2J34pvKUSLWwjSB++bETo6N7hTdLln2aTk7Veiz3 uf1BPoTiNSAfaB1YaBrzjUNxyskcU0GFuKyL9sDaMkrvdCA+QDuKpnVBrOPtBWIVwHA+2O Kwbk0Bl2h14ag9tsATPv6zZ8Obqafsbse/Y90ptjVGv25VLzL4CMhMvcn6dCL98o0w6m4p ScePJcrV9Kk/h2GQNFt1rOu9P86iwjizYdKveAFoaEbrXWip0jEp43eMQstYBw== Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9BD0A5F707; Sat, 22 Jul 2023 12:16:09 +0000 (UTC) Received: from phubs.tethera.net (unknown [IPv6:2607:5300:60:3a9d::1]) by mail.notmuchmail.org (Postfix) with ESMTPS id A19BF5F6D7 for ; Sat, 22 Jul 2023 12:16:06 +0000 (UTC) Received: from tethera.net (fctnnbsc51w-159-2-210-253.dhcp-dynamic.fibreop.nb.bellaliant.net [159.2.210.253]) by phubs.tethera.net (Postfix) with ESMTPS id 72042180172; Sat, 22 Jul 2023 09:16:04 -0300 (ADT) Received: (nullmailer pid 493336 invoked by uid 1000); Sat, 22 Jul 2023 12:16:03 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH] emacs/hello: refresh hello directly Date: Sat, 22 Jul 2023 09:15:56 -0300 Message-Id: <20230722121556.493313-1-david@tethera.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Message-ID-Hash: G6DZPSR7N2ZZWTXKCDU343FUBDGWZVCY X-Message-ID-Hash: G6DZPSR7N2ZZWTXKCDU343FUBDGWZVCY X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: salutis@me.com X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Spam-Score: -3.99 X-Migadu-Queue-Id: 0277D61DED X-Migadu-Spam-Score: -3.99 X-Migadu-Scanner: mx0.migadu.com X-TUID: Baeyz9/+aRpO According to the now deleted commentary, the hack of using run-at-time was needed for Emacs 24. It seems to be no longer needed for Emacs 28.2, and removing it makes further changes to the code simpler. --- emacs/notmuch-hello.el | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) I would appreciate testing with older emacs, particularly emacs 26 diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 4662e704..cbc5fc2a 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -694,11 +694,7 @@ with `notmuch-hello-query-counts'." ;; configuration change, and this is not a new window) (setq do-refresh t))))) (when (and do-refresh notmuch-hello-auto-refresh) - ;; Refresh hello as soon as we get back to redisplay. On Emacs - ;; 24, we can't do it right here because something in this - ;; hook's call stack overrides hello's point placement. - ;; FIXME And on Emacs releases that we still support? - (run-at-time nil nil #'notmuch-hello t)) + (notmuch-hello t)) (unless hello-buf ;; Clean up hook (remove-hook 'window-configuration-change-hook -- 2.40.1