From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: salutis@me.com
Subject: [PATCH] emacs/hello: refresh hello directly
Date: Sat, 22 Jul 2023 09:15:56 -0300 [thread overview]
Message-ID: <20230722121556.493313-1-david@tethera.net> (raw)
According to the now deleted commentary, the hack of using run-at-time
was needed for Emacs 24. It seems to be no longer needed for Emacs
28.2, and removing it makes further changes to the code simpler.
---
emacs/notmuch-hello.el | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
I would appreciate testing with older emacs, particularly emacs 26
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 4662e704..cbc5fc2a 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -694,11 +694,7 @@ with `notmuch-hello-query-counts'."
;; configuration change, and this is not a new window)
(setq do-refresh t)))))
(when (and do-refresh notmuch-hello-auto-refresh)
- ;; Refresh hello as soon as we get back to redisplay. On Emacs
- ;; 24, we can't do it right here because something in this
- ;; hook's call stack overrides hello's point placement.
- ;; FIXME And on Emacs releases that we still support?
- (run-at-time nil nil #'notmuch-hello t))
+ (notmuch-hello t))
(unless hello-buf
;; Clean up hook
(remove-hook 'window-configuration-change-hook
--
2.40.1
next reply other threads:[~2023-07-22 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 12:15 David Bremner [this message]
2024-07-25 8:47 ` [PATCH] emacs/hello: refresh hello directly David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230722121556.493313-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).