From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] CLI/git: use --exclude=false when calling notmuch-search
Date: Sun, 16 Oct 2022 09:49:00 -0300 [thread overview]
Message-ID: <20221016124900.662786-1-david@tethera.net> (raw)
We use notmuch search in two places in notmuch-git.py: to find which
tags have a given prefix, and to see if message with given id exists
locally. In both cases we do not want the presence of exclude tags
(e.g. deleted) to change the results.
---
notmuch-git.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
The effects of this bug are a bit subtle; out of 12324 messages tagged
'deleted', without this fix I was missing 25 messages. That probably
explains why I couldn't come up with a test to demonstrate the
issue. On other hand, I think it is pretty clearly the right thing to
do, even if most people don't notice a change.
diff --git a/notmuch-git.py b/notmuch-git.py
index ceb86fbc..57098aae 100644
--- a/notmuch-git.py
+++ b/notmuch-git.py
@@ -254,7 +254,7 @@ def count_messages(prefix=None):
def get_tags(prefix=None):
"Get a list of tags with a given prefix."
(status, stdout, stderr) = _spawn(
- args=['notmuch', 'search', '--query=sexp', '--output=tags', _tag_query(prefix)],
+ args=['notmuch', 'search', '--exclude=false', '--query=sexp', '--output=tags', _tag_query(prefix)],
stdout=_subprocess.PIPE, wait=True)
return [tag for tag in stdout.splitlines()]
@@ -719,7 +719,7 @@ class DatabaseCache:
self._known[id] = False
else:
(_, stdout, stderr) = _spawn(
- args=['notmuch', 'search', '--output=files', 'id:{0}'.format(id)],
+ args=['notmuch', 'search', '--exclude=false', '--output=files', 'id:{0}'.format(id)],
stdout=_subprocess.PIPE,
wait=True)
self._known[id] = stdout != None
--
2.35.2
next reply other threads:[~2022-10-16 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 12:49 David Bremner [this message]
2022-12-27 15:58 ` [PATCH] CLI/git: use --exclude=false when calling notmuch-search David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221016124900.662786-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).