* [PATCH] emacs/show: use read-shell-command instead of read-string
@ 2022-08-30 14:17 Antoine Beaupré
2022-08-31 17:20 ` Tomi Ollila
2022-09-03 11:22 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Antoine Beaupré @ 2022-08-30 14:17 UTC (permalink / raw)
To: notmuch; +Cc: Antoine Beaupré
This enables auto-completion of commands, something which plain
read-string does not do. It's otherwise a drop-in
replacement. According to `C-h f`, read-shell-command was introduced
in Emacs 23.1 or earlier.
---
emacs/notmuch-show.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 2dcef981..ec998ede 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2192,7 +2192,7 @@ message."
(interactive (let ((query-string (if current-prefix-arg
"Pipe all open messages to command: "
"Pipe message to command: ")))
- (list current-prefix-arg (read-string query-string))))
+ (list current-prefix-arg (read-shell-command query-string))))
(let (shell-command)
(if entire-thread
(setq shell-command
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] emacs/show: use read-shell-command instead of read-string
2022-08-30 14:17 [PATCH] emacs/show: use read-shell-command instead of read-string Antoine Beaupré
@ 2022-08-31 17:20 ` Tomi Ollila
2022-09-03 11:22 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2022-08-31 17:20 UTC (permalink / raw)
To: Antoine Beaupré, notmuch
On Tue, Aug 30 2022, Antoine Beaupré wrote:
> This enables auto-completion of commands, something which plain
> read-string does not do. It's otherwise a drop-in
> replacement. According to `C-h f`, read-shell-command was introduced
> in Emacs 23.1 or earlier.
LGTM.
Tomi
> ---
> emacs/notmuch-show.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 2dcef981..ec998ede 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2192,7 +2192,7 @@ message."
> (interactive (let ((query-string (if current-prefix-arg
> "Pipe all open messages to command: "
> "Pipe message to command: ")))
> - (list current-prefix-arg (read-string query-string))))
> + (list current-prefix-arg (read-shell-command query-string))))
> (let (shell-command)
> (if entire-thread
> (setq shell-command
> --
> 2.30.2
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org\r
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] emacs/show: use read-shell-command instead of read-string
2022-08-30 14:17 [PATCH] emacs/show: use read-shell-command instead of read-string Antoine Beaupré
2022-08-31 17:20 ` Tomi Ollila
@ 2022-09-03 11:22 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2022-09-03 11:22 UTC (permalink / raw)
To: Antoine Beaupré, notmuch; +Cc: Antoine Beaupré
Antoine Beaupré <anarcat@debian.org> writes:
> This enables auto-completion of commands, something which plain
> read-string does not do. It's otherwise a drop-in
> replacement. According to `C-h f`, read-shell-command was introduced
> in Emacs 23.1 or earlier.
Applied to master.
d\r
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-03 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 14:17 [PATCH] emacs/show: use read-shell-command instead of read-string Antoine Beaupré
2022-08-31 17:20 ` Tomi Ollila
2022-09-03 11:22 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).