From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/2] emacs: update notmuch-show-get-filename to handle duplicates
Date: Thu, 4 Aug 2022 08:08:33 -0300 [thread overview]
Message-ID: <20220804110833.322155-2-david@tethera.net> (raw)
In-Reply-To: <20220804110833.322155-1-david@tethera.net>
This fixes one of the bugs reported by Gregor in [1].
[1]: id:87edxw8jp4.fsf@no.workgroup
---
emacs/notmuch-show.el | 4 ++--
test/T450-emacs-show.sh | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1bc3b319..527db4bb 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1811,10 +1811,10 @@ current thread."
;; dme: Would it make sense to use a macro for many of these?
-;; XXX TODO figure out what to do about multiple filenames
(defun notmuch-show-get-filename ()
"Return the filename of the current message."
- (car (notmuch-show-get-prop :filename)))
+ (let ((duplicate (or (notmuch-show-get-prop :duplicate) 1)))
+ (nth (1- duplicate) (notmuch-show-get-prop :filename))))
(defun notmuch-show-get-header (header &optional props)
"Return the named header of the current message, if any."
diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
index 2cebd43d..ab611d56 100755
--- a/test/T450-emacs-show.sh
+++ b/test/T450-emacs-show.sh
@@ -352,7 +352,6 @@ test_expect_equal "$output" "$subject"
FILE3=$(notmuch search --output=files --duplicate=3 "id:${ID3}")
test_begin_subtest "duplicate=3, stash"
-test_subtest_known_broken
test_emacs_expect_t \
"(notmuch-show \"id:${ID3}\")
(notmuch-show-choose-duplicate 3)
--
2.35.2
next prev parent reply other threads:[~2022-08-04 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 11:08 [PATCH 1/2] test/emacs: add known broken test for stashing duplicate filename David Bremner
2022-08-04 11:08 ` David Bremner [this message]
2022-08-04 11:48 ` [PATCH 1/3] test/emacs: add known broken test for viewing raw duplicate David Bremner
2022-08-04 11:48 ` [PATCH 2/3] emacs/show: provide a more friendly function to get duplicate num David Bremner
2022-08-04 11:48 ` [PATCH 3/3] emacs: add duplicate support to notmuch-show-view-raw-message David Bremner
2022-08-07 10:27 ` [PATCH 1/2] test/emacs: add known broken test for stashing duplicate filename David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804110833.322155-2-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).