From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 6/6] lib: check for writable db in n_m_tags_maildir_flags
Date: Wed, 25 May 2022 07:51:17 -0300 [thread overview]
Message-ID: <20220525105117.10709-7-david@tethera.net> (raw)
In-Reply-To: <20220525105117.10709-1-david@tethera.net>
The database needs to be writable because the list of stored file
names will change in general.
---
lib/message.cc | 4 ++++
test/T566-lib-message.sh | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/message.cc b/lib/message.cc
index ae152df7..1df804bc 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -2038,6 +2038,10 @@ notmuch_message_tags_to_maildir_flags (notmuch_message_t *message)
char *to_set, *to_clear;
notmuch_status_t status = NOTMUCH_STATUS_SUCCESS;
+ status = _notmuch_database_ensure_writable (message->notmuch);
+ if (status)
+ return status;
+
_get_maildir_flag_actions (message, &to_set, &to_clear);
for (filenames = notmuch_message_get_filenames (message);
diff --git a/test/T566-lib-message.sh b/test/T566-lib-message.sh
index 3a5e9607..551898c6 100755
--- a/test/T566-lib-message.sh
+++ b/test/T566-lib-message.sh
@@ -373,7 +373,6 @@ EOF
test_expect_equal_file EXPECTED OUTPUT
test_begin_subtest "Handle converting tags to maildir flags with closed db"
-test_subtest_known_broken
cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR}
{
notmuch_status_t status;
--
2.35.2
next prev parent reply other threads:[~2022-05-25 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:51 notmuch_message* error handling cleanup part II David Bremner
2022-05-25 10:51 ` [PATCH 1/6] test: error handling for n_m_tags_to_maildir_flags David Bremner
2022-05-25 10:51 ` [PATCH 2/6] test: add known broken test for notmuch_tags_valid (NULL) David Bremner
2022-05-25 10:51 ` [PATCH 3/6] lib/tag: handle NULL argument to notmuch_tags_valid David Bremner
2022-05-25 10:51 ` [PATCH 4/6] lib: Add missing private status values David Bremner
2022-05-25 10:51 ` [PATCH 5/6] lib: add NOTMUCH_STATUS_CLOSED_DATABASE, use in _n_d_ensure_writable David Bremner
2022-05-25 10:51 ` David Bremner [this message]
2022-06-25 19:38 ` notmuch_message* error handling cleanup part II David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525105117.10709-7-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).