From: David Bremner <david@tethera.net>
To: David Bremner <david@tethera.net>,
Gregor Zattler <telegraph@gmx.net>,
notmuch@notmuchmail.org
Subject: [PATCH 1/2] Revert "emacs: use --exclude=false when checking for empty searches"
Date: Sat, 22 Jan 2022 13:44:39 -0400 [thread overview]
Message-ID: <20220122174440.1573257-2-david@tethera.net> (raw)
In-Reply-To: <20220122174440.1573257-1-david@tethera.net>
Revert commit 8370e3cfe2dd8a79323613c2bbf2f11db6134dac, and remark the
corresponding test as broken. Also update the expected output of the
broken test to show excludes active in the user defined saved searches.
---
emacs/notmuch-hello.el | 2 +-
test/T440-emacs-hello.sh | 1 +
test/emacs.expected-output/notmuch-hello-all-tags | 4 ----
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 9ac52c11..71e91093 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -570,7 +570,7 @@ options will be handled as specified for
(plist-get options :filter))))
"\n")))
(unless (= (notmuch--call-process-region (point-min) (point-max) notmuch-command
- t t nil "count" "--exclude=false" "--batch") 0)
+ t t nil "count" "--batch") 0)
(notmuch-logged-error
"notmuch count --batch failed"
"Please check that the notmuch CLI is new enough to support `count
diff --git a/test/T440-emacs-hello.sh b/test/T440-emacs-hello.sh
index 842781a4..dc80cc75 100755
--- a/test/T440-emacs-hello.sh
+++ b/test/T440-emacs-hello.sh
@@ -69,6 +69,7 @@ notmuch tag -$tag '*'
test_expect_equal_file $EXPECTED/notmuch-hello-long-names OUTPUT
test_begin_subtest "All tags show up"
+test_subtest_known_broken
tag=exclude_me
notmuch tag +$tag '*'
notmuch config set search.exclude_tags $tag
diff --git a/test/emacs.expected-output/notmuch-hello-all-tags b/test/emacs.expected-output/notmuch-hello-all-tags
index 2802a708..65e479fa 100644
--- a/test/emacs.expected-output/notmuch-hello-all-tags
+++ b/test/emacs.expected-output/notmuch-hello-all-tags
@@ -1,9 +1,5 @@
Welcome to notmuch. You have 52 messages.
-Saved searches: [edit]
-
- 52 inbox 52 unread 52 all mail
-
Search: .
All tags: [hide]
--
2.34.1
next prev parent reply other threads:[~2022-01-22 17:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 16:12 Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags Gregor Zattler
2018-04-21 17:38 ` Tomi Ollila
2018-04-21 22:33 ` Gregor Zattler
2018-04-22 8:52 ` Tomi Ollila
2022-01-05 1:06 ` [PATCH 1/3] test/emacs: add known broken test for hidden tags David Bremner
2022-01-05 1:06 ` [PATCH 2/3] emacs: use --exclude=false when checking for empty searches David Bremner
2022-01-05 1:06 ` [PATCH 3/3] emacs: use --exclude=false when counting total messages David Bremner
2022-01-05 11:41 ` David Bremner
2022-01-20 19:49 ` [PATCH 1/3] test/emacs: add known broken test for hidden tags David Bremner
2022-01-20 19:51 ` Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags David Bremner
2022-01-22 14:14 ` confirm bug fixed (was: Bug? notmuch-emacs: "All tags" in notmuch-hello does not show all tags) Gregor Zattler
2022-01-22 15:25 ` David Bremner
2022-01-22 17:44 ` Attempt 2 to fix the all-tags display with excludes David Bremner
2022-01-22 17:44 ` David Bremner [this message]
2022-01-22 17:44 ` [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts David Bremner
2022-01-23 19:00 ` David Bremner
2022-01-23 19:36 ` Gregor Zattler
2022-01-24 2:54 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122174440.1573257-2-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=telegraph@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).