From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cL1NNMVW6WH6kgAAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 13:34:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CI33LMVW6WFxqAAAG6o9tA (envelope-from ) for ; Thu, 20 Jan 2022 13:34:13 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56F983A9DA for ; Thu, 20 Jan 2022 13:34:13 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DB0395F6EF; Thu, 20 Jan 2022 12:34:07 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id CFE9C5F6EC for ; Thu, 20 Jan 2022 12:34:04 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id F133C5FC01; Thu, 20 Jan 2022 07:34:03 -0500 (EST) Received: (nullmailer pid 4003265 invoked by uid 1000); Thu, 20 Jan 2022 12:34:02 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: fix Fcc of signed / encrypted messages. Date: Thu, 20 Jan 2022 08:33:50 -0400 Message-Id: <20220120123354.3999579-1-david@tethera.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Message-ID-Hash: P5YORFL7ZFOLJKUU7P5JNVH3PMTRZQ3N X-Message-ID-Hash: P5YORFL7ZFOLJKUU7P5JNVH3PMTRZQ3N X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642682053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=M1WMXdz9Z5dEDvwkHEybxiN9J3ZA1m2zAV/cxHXtuW8=; b=Yamphm3Zu6sxDjQddD0/Kkwdi9ahQkzvF5nRJvqJbTpEvQ2jx/2cYfBKL2evXADpMNiJfm Qq2qA8cIPEkS09ZPJ8z3T5PnyRpu+FM8vg4nI1sJYrCYMoq8Ux1YXJ3lo2BCDT9r8BLFoQ nZeT/NwAwGNP5aUcu/kDCy2NyTSnHiArp7jA4xYeI9sDtlAjrm9QONo0d+89ma2rFToiEt vRE7OjBvQg2k8tQkkyEfDJjdOtTGc7ul7Po4b3d1CkBYfnXsjv423yIYnmXOEiVcgiEqd3 VFa+e4UJ5cNeR60dYbewRnqKfSkrjpuX1juDBGzeH+uJBpqDhKff/KuTnQEkzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642682053; a=rsa-sha256; cv=none; b=OH82OPSUkxWQmHoOjFkkpz0Q3NoEWhO0WOiaWQdGyQyQbhSUTtLR+RgeQY9BVHCefkHV9X jj72ED/Ne5iQmXLARDaXN4hekAEyLOcYLgBD4MrfqTvaNW4SgwDpfy2Lr8rSKvn3RrtIsR bcMwSFQGTHtJQUvyPz566JkchK0L4oreFSx13GYsS2N9EbQZVqEGqWj8mQBaQATPRQeB0X wVmGUstM7c4omPMwEsdwctB1N4xNTJr+aafcG93ffDwH8CU+rrZNB6nLMMn0LZWuSAYZ2l MK8eGokcs8N8KWFB3QNK9HBUfCtt4QaLvGeuHYo28eYypue2OaEvMDyZ9qWAcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 56F983A9DA X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: cTwmWldKWJQE It turns out that in the years since dkg reported this bug, larsi fixed it in message-do-fcc. Since we in our wisdom copied and modified that function, we missed out on the fix. This series copies the fix from "upstream". It requires a couple of updates to the test suite. Other points to notice: it introduces a call to #'message-clone-locals, and moves the call to notmuch-maildir-setup-message-for-saving.