From: David Bremner <david@tethera.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: [PATCH] CLI: print extra headers only for non-replies
Date: Tue, 18 Jan 2022 21:34:00 -0400 [thread overview]
Message-ID: <20220119013400.3155683-1-david@tethera.net> (raw)
In-Reply-To: <20220119011451.3079127-1-david@tethera.net>
If in the future we decide to output extra headers for replies, this
should be controlled by a separate configuration option.
---
notmuch-show.c | 3 ++-
test/T310-emacs.sh | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 136f4439..6a54d9c1 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -294,7 +294,8 @@ format_headers_sprinter (sprinter_t *sp, GMimeMessage *message,
}
/* Output extra headers the user has configured, if any */
- format_extra_headers_sprinter (sp, message);
+ if (! reply)
+ format_extra_headers_sprinter (sp, message);
sp->end (sp);
talloc_free (local);
}
diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index 831df1cc..a05b828a 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -486,7 +486,6 @@ EOF
test_expect_equal_file EXPECTED OUTPUT
test_begin_subtest "Reply with show.extra_headers set"
-test_subtest_known_broken
notmuch config set show.extra_headers Received
add_message '[from]="Sender <sender@example.com>"' \
[to]=test_suite_other@notmuchmail.org
--
2.34.1
next prev parent reply other threads:[~2022-01-19 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 1:14 [PATCH] test/emacs: known broken test for reply with extra headers set David Bremner
2022-01-19 1:34 ` David Bremner [this message]
2022-01-19 20:47 ` [PATCH] CLI: print extra headers only for non-replies Tomi Ollila
2022-01-20 0:00 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119013400.3155683-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).