From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [RFC Patch 2/3] CLI/address: sort output by frequency with deduplicate=address
Date: Sun, 19 Dec 2021 14:18:53 -0400 [thread overview]
Message-ID: <20211219181854.115918-3-david@tethera.net> (raw)
In-Reply-To: <20211219181854.115918-1-david@tethera.net>
Since the current output is not in any guaranteed order, changing the
output ordering should not break anything.
This is one of the easy cases, since we are already making a complete
pass of the matches and storing them in a hash table.
---
notmuch-search.c | 19 +++++++++++++++----
test/T095-address.sh | 28 ++++++++++++++++++++++++++++
2 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index 47eec601..ff3967fd 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -64,6 +64,7 @@ typedef struct {
int limit;
int dupe;
GHashTable *addresses;
+ GList *output_mailboxes;
int dedup;
} search_context_t;
@@ -507,14 +508,20 @@ print_list_value (void *mailbox, void *context)
print_mailbox (context, mailbox);
}
+static gint
+compare_count (gconstpointer a, gconstpointer b)
+{
+ return ((mailbox_t *) b)->count - ((mailbox_t *) a)->count;
+}
+
static void
-print_hash_value (unused (void *key), void *list, void *context)
+process_hash_value (unused (void *key), void *list, void *context)
{
- const search_context_t *ctx = context;
+ search_context_t *ctx = context;
if (ctx->dedup == DEDUP_ADDRESS) {
mailbox_t *mailbox = summarize_mailboxes (list);
- print_mailbox (ctx, mailbox);
+ ctx->output_mailboxes = g_list_prepend (ctx->output_mailboxes, mailbox);
} else
g_list_foreach (list, print_list_value, context);
}
@@ -621,7 +628,10 @@ do_search_messages (search_context_t *ctx)
if (ctx->addresses &&
(ctx->output & OUTPUT_COUNT || ctx->dedup == DEDUP_ADDRESS)) {
- g_hash_table_foreach (ctx->addresses, print_hash_value, ctx);
+ g_hash_table_foreach (ctx->addresses, process_hash_value, ctx);
+ ctx->output_mailboxes = g_list_sort (ctx->output_mailboxes, compare_count);
+ if (ctx->dedup == DEDUP_ADDRESS)
+ g_list_foreach (ctx->output_mailboxes, print_list_value, ctx);
}
notmuch_messages_destroy (messages);
@@ -910,6 +920,7 @@ notmuch_address_command (notmuch_database_t *notmuch, int argc, char *argv[])
ctx->addresses = g_hash_table_new_full (strcase_hash, strcase_equal,
_talloc_free_for_g_hash,
_list_free_for_g_hash);
+ ctx->output_mailboxes = NULL; /* empty list, according to glib */
/* The order is not guaranteed if a full pass is required, so go
* for fastest. */
diff --git a/test/T095-address.sh b/test/T095-address.sh
index 8bb3627a..53886591 100755
--- a/test/T095-address.sh
+++ b/test/T095-address.sh
@@ -276,6 +276,26 @@ notmuch@notmuchmail.org
EOF
test_expect_equal_file EXPECTED OUTPUT
+test_begin_subtest "--deduplicate=address --output=sender --output=recipients --output=count (sort by frequency)"
+notmuch address --deduplicate=address --output=sender --output=recipients --output=count '*' | head -n 4 >OUTPUT
+cat <<EOF >EXPECTED
+50 notmuch@notmuchmail.org
+12 Carl Worth <cworth@cworth.org>
+8 Keith Packard <keithp@keithp.com>
+6 Alexander Botero-Lowry <alex.boterolowry@gmail.com>
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
+test_begin_subtest "--deduplicate=address --output=sender --output=recipients --output=count (sort by frequency)"
+notmuch address --deduplicate=address --output=sender --output=recipients '*' | head -n 4 >OUTPUT
+cat <<EOF >EXPECTED
+notmuch@notmuchmail.org
+Carl Worth <cworth@cworth.org>
+Keith Packard <keithp@keithp.com>
+Alexander Botero-Lowry <alex.boterolowry@gmail.com>
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
generate_message '[from]="Foo Bar <foo.bar@example.com>"'
generate_message '[from]="Foo Bar <Foo.Bar@Example.Com>"'
generate_message '[from]="Foo Bar <foo.bar@example.com>"'
@@ -325,6 +345,14 @@ cat <<EOF >EXPECTED
EOF
test_expect_equal_file EXPECTED OUTPUT
+test_begin_subtest "--deduplicate=address --output=sender --output=count (sort by frequency)"
+notmuch address --deduplicate=address --output=sender --output=count from:example.com >OUTPUT
+cat <<EOF >EXPECTED
+7 Foo Bar <foo.bar@example.com>
+3 Baz <foo.bar+baz@example.com>
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
if [[ NOTMUCH_HAVE_SFSEXP = 1 ]]; then
test_begin_subtest "sexpr query: all messages"
notmuch address '*' > EXPECTED
--
2.34.1
next prev parent reply other threads:[~2021-12-19 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-19 18:18 Partial support for sorting the output of notmuch address David Bremner
2021-12-19 18:18 ` [RFC Patch 1/3] CLI/address: refactor/inline print_popular David Bremner
2021-12-19 18:18 ` David Bremner [this message]
2021-12-19 18:18 ` [RFC Patch 3/3] CLI/address: source by frequency if output=count David Bremner
2021-12-20 16:48 ` Partial support for sorting the output of notmuch address inwit
2021-12-20 17:44 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211219181854.115918-3-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).