From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oPZfCdWvfWHRWAAAgWs5BA (envelope-from ) for ; Sat, 30 Oct 2021 22:49:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cEfaBNWvfWGuXAAAbx9fmQ (envelope-from ) for ; Sat, 30 Oct 2021 20:49:25 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CCAC569AA for ; Sat, 30 Oct 2021 22:49:24 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 94FC61FCD3; Sat, 30 Oct 2021 16:49:10 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 813F61FA89 for ; Sat, 30 Oct 2021 16:49:03 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 328645FC42; Sat, 30 Oct 2021 16:49:02 -0400 (EDT) Received: (nullmailer pid 1581633 invoked by uid 1000); Sat, 30 Oct 2021 20:48:58 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: [PATCH 2/3] ruby: don't use a directory as a target. Date: Sat, 30 Oct 2021 17:48:54 -0300 Message-Id: <20211030204855.1581540-3-david@tethera.net> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211030204855.1581540-1-david@tethera.net> References: <87r29wwgq2.fsf@fifthhorseman.net> <20211030204855.1581540-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: KASGJCY455L6ZANYUJVJJZ4CTDJ3GV7N X-Message-ID-Hash: KASGJCY455L6ZANYUJVJJZ4CTDJ3GV7N X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635626964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=uSFqQwYJZoG7K+eI/zkykMgJPjy8IaoPIbwrUSklNMM=; b=G8sLj2qqsYyuoCT/awKwabhHmrgHiNpZwiOtrKU1ecPdf/G5zwFsMgFmmzMvcjFYfjyiis NqLMY8HymYXgVOCKGnFX/L4yQX5BGlTwNeBdNpJgQkQ6Hngz/PwtilCkm4XP8Dg+zBwBeN nRzxLQKtDhc149MTUw7JbMFo6xMD2b+x4yhzrMHkcni6ZhGxoRAB9zPGe1fBOX1FMjdELo CkF9JyJ+Kmyvo8Ui3rUi1tTnFqaE5fu3y4RYZNePM+Y20h/H1djx3BGoiSMkD2JCFZGo+7 Np83plb4sjX928IEJobErPQg9gx/DAbLeCS7SVJb8nSzEqFIExv/xr7Iwf6GuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635626964; a=rsa-sha256; cv=none; b=p5dOXamW6i6774elmQaniH2jqMzBs8jr7GBBEocFkF9dGagCeynOqVry2DGrhyC+w+EE+3 bb3hrWYd0MeEI8KEgtS5750lOHOdXBS7LZ951qABwrk9yR9YIle3ZiCACxyVBbqetmQnvm GPz4lShvaQi0XK3GH6LxPolNme0UDXXGvcHtqZ9rNjjMEk/d8VmbttHgT3I1gCGxYmKdXp Xe8E8I/UnMitlFwmYBPTjZ7mGeN4jAWSQTlNMpy5TJLgpMB2mi2rwoE08McDs0NNXVXGKG 2aBtlm3ctaG8fWHkFVYHvc1D/hxNhzTN/Ren5oCc7VxZqfQZhfCBbQZDyq0/2A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.15 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: CCAC569AA X-Spam-Score: -1.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: mgmT9eRZwonC The directory is (neccesarily) not updated by the build, so it keeps trying to build. The proposed fix is to use the name of the dynamic library containing the extension. This is a partial fix for the rebuilding reported at [1]. [1]: id:87r29wwgq2.fsf@fifthhorseman.net --- bindings/Makefile.local | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/bindings/Makefile.local b/bindings/Makefile.local index 3672e69f..1cdd28a0 100644 --- a/bindings/Makefile.local +++ b/bindings/Makefile.local @@ -3,21 +3,23 @@ dir := bindings # force the shared library to be built -ruby-bindings: lib/$(LINKER_NAME) +ruby-bindings: $(dir)/ruby.stamp + +$(dir)/ruby.stamp: lib/$(LINKER_NAME) ifeq ($(HAVE_RUBY_DEV),1) cd $(dir)/ruby && \ EXTRA_LDFLAGS="$(NO_UNDEFINED_LDFLAGS)" \ LIBNOTMUCH="../../lib/$(LINKER_NAME)" \ NOTMUCH_SRCDIR='$(NOTMUCH_SRCDIR)' \ $(RUBY) extconf.rb --vendor - $(MAKE) -C $(dir)/ruby CFLAGS="$(CFLAGS) -pipe -fno-plt -fPIC" + $(MAKE) -C $(dir)/ruby CFLAGS="$(CFLAGS) -pipe -fno-plt -fPIC" && touch $@ endif python-cffi-bindings: lib/$(LINKER_NAME) ifeq ($(HAVE_PYTHON3_CFFI),1) cd $(dir)/python-cffi && \ ${PYTHON} setup.py build --build-lib build/stage && \ - mkdir -p build/stage/tests && cp tests/*.py build/stage/tests + mkdir -p build/stage/tests && cp tests/*.py build/stage/tests && touch ../../$@ endif CLEAN += $(patsubst %,$(dir)/ruby/%, \ @@ -26,6 +28,6 @@ CLEAN += $(patsubst %,$(dir)/ruby/%, \ init.o message.o messages.o mkmf.log notmuch.so query.o \ status.o tags.o thread.o threads.o) -CLEAN += bindings/ruby/.vendorarchdir.time +CLEAN += bindings/ruby/.vendorarchdir.time $(dir)/ruby.stamp CLEAN += bindings/python-cffi/build -- 2.33.0