unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: David Bremner <david@tethera.net>,
	"Jorge P. de Morais Neto" <jorge+list@disroot.org>,
	notmuch@notmuchmail.org
Subject: [PATCH v2] emacs: drop C-tab binding in hello mode, document <backtab>.
Date: Sat, 30 Oct 2021 15:58:16 -0300	[thread overview]
Message-ID: <20211030185816.1541058-1-david@tethera.net> (raw)
In-Reply-To: <20211030183502.1510576-1-david@tethera.net>

The <backtab> binding has always been there, but the docs were
apparently mistakenly changed to say <backspace> [1]

Revert to <backtab> in the documentation.

The commit also drops the C-<tab> binding, since it seems redundant
and it interferes with tab-bar-mode.

[1]: 703dec7754da477b5683867c88cb940b8553be91.
---
 doc/notmuch-emacs.rst  | 2 +-
 emacs/notmuch-hello.el | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst
index 12ee25e5..22aee340 100644
--- a/doc/notmuch-emacs.rst
+++ b/doc/notmuch-emacs.rst
@@ -56,7 +56,7 @@ notmuch-hello key bindings
 ``<tab>``
     Move to the next widget (button or text entry field)
 
-``<backspace>``
+``<backtab>``
     Move to the previous widget.
 
 ``<return>``
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 71487bd9..acd48c9b 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -702,7 +702,6 @@ with `notmuch-hello-query-counts'."
   ;; that when we modify map it does not modify widget-keymap).
   (let ((map (make-composed-keymap (list (make-sparse-keymap) widget-keymap))))
     (set-keymap-parent map notmuch-common-keymap)
-    (define-key map (kbd "<C-tab>") 'widget-backward)
     map)
   "Keymap for \"notmuch hello\" buffers.")
 
-- 
2.33.0

  parent reply	other threads:[~2021-10-30 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 17:05 Notmuch Emacs 0.31.2 documentation and keybinding suggestions Jorge P. de Morais Neto
2021-10-11  1:15 ` David Bremner
2021-10-11 16:49   ` Jose Antonio Ortega Ruiz
2021-10-28 23:33   ` Jorge P. de Morais Neto
2021-10-11 11:19 ` [PATCH] emacs: add minimal docstring for notmuch-unthreaded David Bremner
2021-10-23 13:12   ` [PATCH] emacs: improve notmuch-*-from-current-query docstrings David Bremner
2021-10-30 18:22   ` [PATCH] emacs: add minimal docstring for notmuch-unthreaded David Bremner
2021-10-30 18:35     ` [PATCH] emacs: drop C-tab binding in hello mode, document <backtab> David Bremner
2021-10-30 18:39       ` Ralph Seichter
2021-10-30 18:51         ` David Bremner
2021-10-30 18:58       ` David Bremner [this message]
2021-11-03 22:04         ` [PATCH v2] " Tomi Ollila
2021-12-04  0:30         ` David Bremner
2021-12-05 12:39 ` Notmuch Emacs 0.31.2 documentation and keybinding suggestions David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211030185816.1541058-1-david@tethera.net \
    --to=david@tethera.net \
    --cc=jorge+list@disroot.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).