unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Ray <austin@austinray.io>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: WIP fixes for nulling of database argument on error
Date: Sat, 23 Oct 2021 09:12:43 -0400	[thread overview]
Message-ID: <20211023131243.tirmjrtctprcjpcm@athena> (raw)
In-Reply-To: <20211023092451.1403141-1-david@tethera.net>


[-- Attachment #1.1: Type: text/plain, Size: 259 bytes --]

Hi David,

This resolves both the non-NULL pointer and memory leak reported by
ASAN.

Thanks!

Austin

-- 
https://austinray.io
Open Source Maintainer, Software Engineer, Keyboard Enthusiast
GPG: 0127 ED83 B939 CCC9 8082 476E 1AA0 B115 C8AC 2C9E

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      parent reply	other threads:[~2021-10-23 13:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 19:04 notmuch_database_open_with_config() does not NULL pointer on error Austin Ray
2021-10-23  4:22 ` Austin Ray
2021-10-23  9:24   ` WIP fixes for nulling of database argument " David Bremner
2021-10-23  9:24     ` [PATCH 1/5] test: add two known broken tests for missing config files David Bremner
2021-10-23  9:24     ` [PATCH 2/5] lib/open: fix potential double-free, ensure *database=NULL on error David Bremner
2021-10-23  9:24     ` [PATCH 3/5] lib/open: document expectations for db on error, add tests David Bremner
2021-10-23  9:24     ` [PATCH 4/5] lib/create: fix memory leak, ensure *database=NULL on error David Bremner
2021-10-23  9:24     ` [PATCH 5/5] lib/load_config: document expectations for db on error, add tests David Bremner
2021-10-23 13:12     ` Austin Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211023131243.tirmjrtctprcjpcm@athena \
    --to=austin@austinray.io \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).