unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Ray <austin@austinray.io>
To: notmuch@notmuchmail.org
Subject: notmuch_database_open_with_config() does not NULL pointer on error
Date: Thu, 21 Oct 2021 15:04:01 -0400	[thread overview]
Message-ID: <20211021190401.imirxau2ewke6e2m@athena> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1308 bytes --]

Submitting this bug report per bremner's request (thanks for the assist
today!)

The documentation for 'notmuch_database_open_with_config()' states:

> In case of any failure, this function returns an error status and
> sets *database to NULL.

However, it's possible to trigger a failure and leave *database in a
partially initialized state. Usage of this pointer causes a segfault in
libnotmuch.

Below is a small reproducer program that causes a no config file failure
and outputs if it has a non-NULL database pointer.

#include <notmuch.h>
#include <stdio.h>

int main() {
  const char *db_path = "/home/aray/mail/";
  notmuch_database_t *db = NULL;

  notmuch_status_t st = notmuch_database_open_with_config(
      db_path, NOTMUCH_DATABASE_MODE_READ_ONLY, NULL, NULL, &db, NULL);

  if (st != NOTMUCH_STATUS_SUCCESS) {
    printf("Received status: %s\n", notmuch_status_to_string(st));
    if (db) {
      printf("Received non-null DB pointer\n");
      return -1;
    }
  }

  return 0;
}

Please set 'db_path' to your notmuch database path and call the program
like such: NOTMUCH_CONFIG="./nonexistent" ./reprod

-- 
https://austinray.io
Open Source Maintainer, Software Engineer, Keyboard Enthusiast
GPG: 0127 ED83 B939 CCC9 8082 476E 1AA0 B115 C8AC 2C9E

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2021-10-21 19:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 19:04 Austin Ray [this message]
2021-10-23  4:22 ` notmuch_database_open_with_config() does not NULL pointer on error Austin Ray
2021-10-23  9:24   ` WIP fixes for nulling of database argument " David Bremner
2021-10-23  9:24     ` [PATCH 1/5] test: add two known broken tests for missing config files David Bremner
2021-10-23  9:24     ` [PATCH 2/5] lib/open: fix potential double-free, ensure *database=NULL on error David Bremner
2021-10-23  9:24     ` [PATCH 3/5] lib/open: document expectations for db on error, add tests David Bremner
2021-10-23  9:24     ` [PATCH 4/5] lib/create: fix memory leak, ensure *database=NULL on error David Bremner
2021-10-23  9:24     ` [PATCH 5/5] lib/load_config: document expectations for db on error, add tests David Bremner
2021-10-23 13:12     ` WIP fixes for nulling of database argument on error Austin Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211021190401.imirxau2ewke6e2m@athena \
    --to=austin@austinray.io \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).