From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YFpFNwTnZmGkQQEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 16:02:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cLbsMgTnZmFpSwAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 14:02:44 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE2E423525 for ; Wed, 13 Oct 2021 16:02:43 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BA6BF2C1A3; Wed, 13 Oct 2021 10:02:41 -0400 (EDT) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by mail.notmuchmail.org (Postfix) with ESMTPS id 76A112C1A2 for ; Wed, 13 Oct 2021 10:02:39 -0400 (EDT) Received: by mail-lf1-x12b.google.com with SMTP id u18so12244391lfd.12 for ; Wed, 13 Oct 2021 07:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=atwMtmdIIoDWwjXYrox5KMcIk0mO28nTfzKsLdtUzYA=; b=2qFIFT4VD1gTTpaFbjHA+sZukE9yN/x82A79q/DuqiHjMjzu2yWP0tKbzXlZg4GVIK wzzgQyfOPl0Df1sROi9o3Dm2qFSCz3n/5uE99czc6kVp52XKwqZcvp3CNF+8NbTBvBAf uhX2Y0BUV1go1XTXGtVqZ8EUWFO3I65fUQbvfSVuc1FjaC2m4J4CCt3iUaQJlAyzVIyY oY0GSrC4aK2n6C9hb7iYTxx+PFeHw7Kf55CopdKsbsdi32YF5E8mJNSVAnAzXs9JhFnS MsfP4DqiXbriiRjkT1MmKQotzhnPHZ/FJiPLw64GUBm52ZgWNoFivBH0L0b4CwrT6dt5 XBiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=atwMtmdIIoDWwjXYrox5KMcIk0mO28nTfzKsLdtUzYA=; b=RilE7avr3Dsl9FuLOKzBgqGAe7fdMZ9fJXayQZHt+dcfz9tPl/rXhsZn+sAVaESwtG rEN+e4Z8ViufmUqh1P0/y8Zljv0136oENXXbLbV6411feq1AitlgO2Xmy3GUFpktz6nB bjijT3vwai5rXziQ2ZTDBA4HEcYvuZ8gik5BcMGF/TPXtWgdqtzJiBHqFKS26nDN5DHu AmYLmzk4m7XynCkMRewt3r1L8iV8c1G8qHtl/A2EMi2AgH1nkNZLhL9IXM9FI4xfjHy/ sf2Kij8OiVWgxmDSqX/Cx76ZwTTqE3kgS1YFbGND66JriaxmBi5jyZCZXr8NtlqjsgaB lULA== X-Gm-Message-State: AOAM531TIVVif8yAWr9m5cmoWYmtZVftaTLprpBrOVpA3fJagmxdCC99 VW+BzhUJexnJ+JHjHTzL8eTQn26DZEA4uVHAMvM= X-Google-Smtp-Source: ABdhPJyjTRiqy0FkMaSgx6AxkOJOQIQirfa6YyBB2GwSp0LNLQ3dscEynWLR0ETPiKqUljfH8WQkOA== X-Received: by 2002:ac2:4345:: with SMTP id o5mr39953601lfl.0.1634133743582; Wed, 13 Oct 2021 07:02:23 -0700 (PDT) Received: from localhost (87-95-50-104.bb.dnainternet.fi. [87.95.50.104]) by smtp.gmail.com with ESMTPSA id 19sm1272271lfy.190.2021.10.13.07.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:02:23 -0700 (PDT) From: Jani Nikula To: notmuch@notmuchmail.org Cc: jani@nikula.org Subject: [PATCH 2/2] cli: remove enum names from typedefs Date: Wed, 13 Oct 2021 17:02:17 +0300 Message-Id: <20211013140217.219926-2-jani@nikula.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211013140217.219926-1-jani@nikula.org> References: <20211013140217.219926-1-jani@nikula.org> MIME-Version: 1.0 Message-ID-Hash: NSKEIFS2KPDJR4UZW66WRRLADXZO5X6A X-Message-ID-Hash: NSKEIFS2KPDJR4UZW66WRRLADXZO5X6A X-MailFrom: jani@nikula.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634133764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=9n9e4lEO4MfT00fTCXutgiQic9g97oQ8AacPhSJ8FFs=; b=KjLkXPua07sW8JND9Cnomhgx1mfJbnndbOmCHJBc+JR7q2QgZXmFypFAYovlDrYJf+5HRf 9ZsJgun97LybL8Y6agWtxBrL2LJP9diKI840rmbxpVLyLQwkL1g+q5rFRIBqmuTjaNioy4 b4FUVk0KePpF61Wk8SdDTQlp2SQXzBQJUJb+IWsp4ah0f3Bh0/nLRSxeDtJfNJT9+XeS+N W6Sjqi9nRQKnDJzb5Kq82UEHcy3ZPUbGBdS5MRJMqRn3AWM7CgVXD6+egRkNpF626ws1e/ vk89kBLnquK+V6CHYn7WTdwCFLUomQ/wbvhIhz2hDQhDLZjOCqrchab2eK6gtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634133764; a=rsa-sha256; cv=none; b=QXv1UWlE+AY/FloRCmQbTWiPgTUhBI0tdQRs+hWGPfxiNRizeKczCqr/btgUdxX3S5rlTX +tTyErmuNmFV9I+Xx2D/6Uin0ERqCXc3beMJnShc6zLJenpz8NhPicL0XYR0KMa2BrkCSt 8As+GnEnwXHGdL1pBBPN3xXaMqkJAw+XP3QJ2vd7KD5Ysw9HImimsMNZ1SsWfDkojP4pss UBcskriUDbghRZGyF28bMpsoHKpFcBaIv1Ee5c1UkOoIQrESRcdEirS6MettuG7l7MmQ1P T2nKGnWEyPRYVVtZtHNpXQhZu5FW9F6Oe8+mNyVrfm87i3lWvA0xOFHrwAcCeg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=2qFIFT4V; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=2qFIFT4V; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: EE2E423525 X-Spam-Score: -0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7EB/hpWxiHaI There are some enum typedefs with the enum name: typedef enum _name_t { ... } name_t; We don't need or use the enum names _name_t for anything, and not all of the enum typedefs have them. We have the typedefs specifically to use the typedef name. Use the anonymous enum in the typedefs: typedef enum { ... } name_t; --- notmuch-client.h | 4 ++-- util/hex-escape.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index 96d81166d2f5..82ae44e429fc 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -426,13 +426,13 @@ mime_node_seek_dfs (mime_node_t *node, int n); const _notmuch_message_crypto_t * mime_node_get_message_crypto_status (mime_node_t *node); -typedef enum dump_formats { +typedef enum { DUMP_FORMAT_AUTO, DUMP_FORMAT_BATCH_TAG, DUMP_FORMAT_SUP } dump_format_t; -typedef enum dump_includes { +typedef enum { DUMP_INCLUDE_TAGS = 1, DUMP_INCLUDE_CONFIG = 2, DUMP_INCLUDE_PROPERTIES = 4 diff --git a/util/hex-escape.h b/util/hex-escape.h index 8703334cda8d..83a4c6f146fe 100644 --- a/util/hex-escape.h +++ b/util/hex-escape.h @@ -5,7 +5,7 @@ extern "C" { #endif -typedef enum hex_status { +typedef enum { HEX_SUCCESS = 0, HEX_SYNTAX_ERROR, HEX_OUT_OF_MEMORY -- 2.30.2