From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MK1zDvrmZmF8RQEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 16:02:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iM0iCvrmZmGuTgAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 14:02:34 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A899FD831 for ; Wed, 13 Oct 2021 16:02:33 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4ACB72C19D; Wed, 13 Oct 2021 10:02:30 -0400 (EDT) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by mail.notmuchmail.org (Postfix) with ESMTPS id 41BA52C19A for ; Wed, 13 Oct 2021 10:02:27 -0400 (EDT) Received: by mail-lf1-x12a.google.com with SMTP id y26so12304798lfa.11 for ; Wed, 13 Oct 2021 07:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/5l4keIIHvFGsMIOm7ciz//AoMx1oFTcQY4FD8tRBOA=; b=LmI6uoEY6koMBeV/PlG7Omh220lUzmmlclMGtM6Tp6s0keMlr4esUd+T7Bc1551hH2 l/3MnP5VS2/XhVw7zT36h8tKJ7onUf0/rcB5GhPYmw8aihAf+keSGGiT5DPe8yvDb84+ Nqd4cUt7066NwiekwOTF6l2jXP1yszo4DjRT7iItuS0HlGMX0VEaBHl9Fru4QnVVFohw mqs47AiwAMEBliF/kOeiXtYxg/gUMMO5bP5i4pyAV6MU9cUkAUqaYtYDaQVhzpmfjfMN 62gQScYf73ubZ+cumwj2upI/y8YWr4HiYXFPCKB32AS3cTNt69ns+w2uKBcf1qKTgDYR 2X2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/5l4keIIHvFGsMIOm7ciz//AoMx1oFTcQY4FD8tRBOA=; b=y3hvH0CHlNLDrpJqdYhcGJzA7s1+Ojo47Xz7nOnuOFU+NGci2NE8yT0NvQHcPj850r 8k3iV0YbWuhsGnQTeF45tPnTrz1kDje9+AJmT1Mlff4EC3XTaBYk970JXRcIYWud4v2H ZdtdH/Bqk+YuNcC6Vsjfwq36Fez2OZtKH6HXCOVK9kFKFK2YX7Td9slWrqdD5N0ztqyG 2DFXZrM0MelgiS/IzPsSaRf4vv+nV7S0q/q6WxVn2WnDE8wg9vYbW/16WQoryrMIW+TK abFCn/mnGqaIRy/QCzJPGDi4nvqazU1tj0WP8HHyxnZ2egTZN6gewI8+2siG7srNpRFj WDoA== X-Gm-Message-State: AOAM5325C1XTkPmpfAVdlX8FQ+5A4NzBVCCk6MqyaL9va/WNYUM6NaWo AG18a+uUEEHQj0h71U2W507Bzanj+8TODtFch30= X-Google-Smtp-Source: ABdhPJzO+ml7KH59hRvXe2s6WsaX/upuBF7a/4obPR/uixy6H1KtPUJyhVgF7P+h/O74GhNSwVla5g== X-Received: by 2002:a2e:9947:: with SMTP id r7mr16202374ljj.162.1634133741588; Wed, 13 Oct 2021 07:02:21 -0700 (PDT) Received: from localhost (87-95-50-104.bb.dnainternet.fi. [87.95.50.104]) by smtp.gmail.com with ESMTPSA id j27sm1340684lfp.261.2021.10.13.07.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:02:21 -0700 (PDT) From: Jani Nikula To: notmuch@notmuchmail.org Cc: jani@nikula.org Subject: [PATCH 1/2] lib: remove enum names from typedefs Date: Wed, 13 Oct 2021 17:02:16 +0300 Message-Id: <20211013140217.219926-1-jani@nikula.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Message-ID-Hash: N4BRB52D7XXJKAH4GZXXWUFXINVWOCDO X-Message-ID-Hash: N4BRB52D7XXJKAH4GZXXWUFXINVWOCDO X-MailFrom: jani@nikula.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634133753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=RxXCab7/UE6RQiF1rty/3/F4B3aSYMBcVYlca2RXRtU=; b=Py0SZ3Geq+TpBI1C2XzeZ1zbhl48Lc2hnvM8lTsuj6aDPKH4PWW0zOWhTgV9u/Br6+OnqK FM6vh+Uuyt8dYD7JzlPArN6YVt27g+glFCHwOfFW5QzKn82fC5Ewc3Q3DMOjExelB9QcyM KZIg4KwNBMbasbL4lwzVZ9Gv9HsOwUz3WbLw9ZcZrO53gglsp//NbpcnWE6GCzrvIO1LDf 1dcdUIaJqToC6BLA0cM2UbM6aRAaeiM623zhDTKd1ZzvNJUcs41V0kboTZUzA1CVnHciQ9 9I5RKaCrtVCDcS6UJitk2k+/S3SstjsJCxJlg03bfAK9x7LaMcu/+t9gIG0ZPw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634133753; a=rsa-sha256; cv=none; b=UyZanwBnuCfcerkAqvIyBnyBTUDqLe2xuRd0z0S9FHH+psU9SbuRnwwwj666DsfINeYRbz /lSe3nMCcrxT9kNGLsYbVQDJCg1LPyaN1UPDyzgFbP4Pd3siByXL37XUOrY1Dn0CruBooH P83xSYIbLwbNuzCEkKX6quPUunvpyzf0G5PnUhOlr8NmOzh8jPYxm1Z4FATJOK87S41SYA 6hKQyzkima9XDppJh2QDXSBB9+sw82D8jJ0xaMGf65rtsY1wSWyJU93pbhzRt5rNKz4UPz cZrzZNmPFl98RUWEjCE4EpyC3JtO1SK96KDG0pG0F0u6x3R8jMura54Lrq2NnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=LmI6uoEY; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=LmI6uoEY; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A899FD831 X-Spam-Score: -0.17 X-Migadu-Scanner: scn1.migadu.com X-TUID: ySkVyzzmiVyV There are some enum typedefs with the enum name: typedef enum _name_t { ... } name_t; We don't need or use the enum names _name_t for anything, and not all of the enum typedefs have them. We have the typedefs specifically to use the typedef name. Use the anonymous enum in the typedefs: typedef enum { ... } name_t; --- lib/database-private.h | 2 +- lib/notmuch-private.h | 4 ++-- lib/notmuch.h | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 8b9d67feec70..7a0450515f44 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -160,7 +160,7 @@ operator&= (_notmuch_features &a, _notmuch_features b) /* * Configuration options for xapian database fields */ -typedef enum notmuch_field_flags { +typedef enum { NOTMUCH_FIELD_NO_FLAGS = 0, NOTMUCH_FIELD_EXTERNAL = 1 << 0, NOTMUCH_FIELD_PROBABILISTIC = 1 << 1, diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h index 093c29b1bbc5..e9ce74a4b178 100644 --- a/lib/notmuch-private.h +++ b/lib/notmuch-private.h @@ -121,7 +121,7 @@ typedef enum { */ #define NOTMUCH_MESSAGE_ID_MAX (200 - sizeof (NOTMUCH_METADATA_THREAD_ID_PREFIX)) -typedef enum _notmuch_private_status { +typedef enum { /* First, copy all the public status values. */ NOTMUCH_PRIVATE_STATUS_SUCCESS = NOTMUCH_STATUS_SUCCESS, NOTMUCH_PRIVATE_STATUS_OUT_OF_MEMORY = NOTMUCH_STATUS_OUT_OF_MEMORY, @@ -173,7 +173,7 @@ typedef enum _notmuch_private_status { (notmuch_status_t) private_status) /* Flags shared by various lookup functions. */ -typedef enum _notmuch_find_flags { +typedef enum { /* Lookup without creating any documents. This is the default * behavior. */ NOTMUCH_FIND_LOOKUP = 0, diff --git a/lib/notmuch.h b/lib/notmuch.h index 546643e80cbb..ca5878a949bc 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -112,7 +112,7 @@ typedef int notmuch_bool_t; * A zero value (NOTMUCH_STATUS_SUCCESS) indicates that the function * completed without error. Any other value indicates an error. */ -typedef enum _notmuch_status { +typedef enum { /** * No error occurred. */ @@ -1678,7 +1678,7 @@ notmuch_message_reindex (notmuch_message_t *message, /** * Message flags. */ -typedef enum _notmuch_message_flag { +typedef enum { NOTMUCH_MESSAGE_FLAG_MATCH, NOTMUCH_MESSAGE_FLAG_EXCLUDED, @@ -2524,7 +2524,7 @@ notmuch_config_list_destroy (notmuch_config_list_t *config_list); /** * Configuration keys known to libnotmuch */ -typedef enum _notmuch_config_key { +typedef enum { NOTMUCH_CONFIG_FIRST, NOTMUCH_CONFIG_DATABASE_PATH = NOTMUCH_CONFIG_FIRST, NOTMUCH_CONFIG_MAIL_ROOT, -- 2.30.2