From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yFnqDEbxVWGdxAAAgWs5BA (envelope-from ) for ; Thu, 30 Sep 2021 19:17:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cMCZCEbxVWGqJQAA1q6Kng (envelope-from ) for ; Thu, 30 Sep 2021 17:17:58 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7DDEA2660C for ; Thu, 30 Sep 2021 19:17:57 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1E4CC26D8C; Thu, 30 Sep 2021 13:17:55 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id C2E8726D8A for ; Thu, 30 Sep 2021 13:17:52 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id B6A965FD5C; Thu, 30 Sep 2021 13:17:52 -0400 (EDT) Received: (nullmailer pid 4044630 invoked by uid 1000); Thu, 30 Sep 2021 17:17:51 -0000 From: David Bremner To: notmuch@notmuchmail.org, Ciprian Dorin Craciun Cc: David Bremner Subject: [PATCH 1/2] test: known broken tests for leading/trailing ws in config Date: Thu, 30 Sep 2021 14:17:47 -0300 Message-Id: <20210930171748.4044617-1-david@tethera.net> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: MIME-Version: 1.0 Message-ID-Hash: LUT6BZ4PZ7LRMRL65RCQJ77GKTTCPCBO X-Message-ID-Hash: LUT6BZ4PZ7LRMRL65RCQJ77GKTTCPCBO X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633022277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Qv/ONxjnY0yzlVxt3XLHe7KDI38wYL+6sBU82oyCHmY=; b=KMrYQKWijAa5vCXAGmwzLiVxYjILep0BE71FrdRCRA/1OGE8nWRccVBeuVL7azzeDU55J/ Hv8wk8hyjCDJjAlXFh4jcrUv9RVb4r1W9BaRLGuuvgb7cFkBFxr1dJu6h7mXVsO+sG5WHr TDLB4dFKFLNEquAxmj2y65QjJyEc/KnWd8dY7aUjMVld8Ecp0KGnG2YBGgaz+JFFfugSoa baLc+wHd1k1m6DvwouZlnA8P2oSouHjTbncbPPjJLVjppNgZbXWdwUuirPiOwLfD58rwBK zubcIZuqeBe1zXryRROrEJR4wxZwQBquepd7CIlKbwWxtKj28cIj7iJv/CQwqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633022277; a=rsa-sha256; cv=none; b=lJd8XqN4bUYZzpX23hIRKOunqDW0auxaXozEXxsh5FZaReURrAJ7sKkC33qCCMKf6UKpYd 7eDOoYGorQtjvt1WjppvjxLl/t/0UGoI01vyXAYYxQ6Q+nDpDPjuNipA6WvuJ4MqceZfuN Ae6/wgYDj0lm42pt58N3VXKt5dpxKqd5p98uUobY+nOetTqRVITWD6+Xj4O9fz0672UoOS ACFrOgsh+cGmjnIVRXP1UDxCaFN3mWOvPmN2gSPOQYqwc5E6k5vjhxkCKwelcwdhCnADxr lGKaaqfJf2KCETR3mKHiGXA9/54UjXR3HugazoyXsQ8j7V2cYku1Wi4GgYjU4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7DDEA2660C X-Spam-Score: -0.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: oc0w0PlWpQ3z These tests duplicate the bug/misfeature reported in id:CA+Tk8fzjPLaEd3vL1f9ebk_bF_RV8PDTLzDupraTkCLCpJAmCg@mail.gmail.com --- test/T050-new.sh | 13 +++++++++++++ test/T070-insert.sh | 13 +++++++++++++ test/T590-libconfig.sh | 24 ++++++++++++++++++++++++ 3 files changed, 50 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 1141c1e3..bc20440b 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh @@ -329,6 +329,19 @@ notmuch config set new.tags "foo;;bar" output=$(NOTMUCH_NEW --quiet 2>&1) test_expect_equal "$output" "" +test_begin_subtest "leading/trailing whitespace in new.tags is ignored" +test_subtest_known_broken +# avoid complications with leading spaces and "notmuch config" +sed -i 's/^tags=.*$/tags= fu bar ; ; bar /' notmuch-config +add_message +NOTMUCH_NEW --quiet +notmuch dump id:$gen_msg_id | sed 's/ --.*$//' > OUTPUT +cat <EXPECTED +#notmuch-dump batch-tag:3 config,properties,tags ++bar +fu%20bar +EOF +test_expect_equal_file EXPECTED OUTPUT + test_begin_subtest "Tags starting with '-' in new.tags are forbidden" notmuch config set new.tags "-foo;bar" output=$(NOTMUCH_NEW --debug 2>&1) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 208deb1c..9d29c859 100755 --- a/test/T070-insert.sh +++ b/test/T070-insert.sh @@ -234,6 +234,19 @@ output=$(notmuch show --format=json id:$gen_msg_id) test_json_nodes <<<"$output" \ 'new_tags:[0][0][0]["tags"] = ["bar", "foo"]' +test_begin_subtest "leading/trailing whitespace in new.tags is ignored" +test_subtest_known_broken +# avoid complications with leading spaces and "notmuch config" +sed -i 's/^tags=.*$/tags= fu bar ; ; bar /' notmuch-config +gen_insert_msg +notmuch insert < $gen_msg_filename +notmuch dump id:$gen_msg_id | sed 's/ --.*$//' > OUTPUT +cat <EXPECTED +#notmuch-dump batch-tag:3 config,properties,tags ++bar +fu%20bar +EOF +test_expect_equal_file EXPECTED OUTPUT + test_begin_subtest "Tags starting with '-' in new.tags are forbidden" notmuch config set new.tags "-foo;bar" gen_insert_msg diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh index 59b82a6f..88647940 100755 --- a/test/T590-libconfig.sh +++ b/test/T590-libconfig.sh @@ -272,6 +272,30 @@ EOF test_expect_equal_file EXPECTED OUTPUT restore_database +test_begin_subtest "notmuch_config_get_values (ignore leading/trailing whitespace)" +test_subtest_known_broken +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% +{ + notmuch_config_values_t *values; + EXPECT0(notmuch_config_set (db, NOTMUCH_CONFIG_NEW_TAGS, " a ; b c ; d ")); + for (values = notmuch_config_get_values (db, NOTMUCH_CONFIG_NEW_TAGS); + notmuch_config_values_valid (values); + notmuch_config_values_move_to_next (values)) + { + puts (notmuch_config_values_get (values)); + } +} +EOF +cat <<'EOF' >EXPECTED +== stdout == +a +b c +d +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT +restore_database + test_begin_subtest "notmuch_config_get_values_string" cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { -- 2.33.0