unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Ray <austin@austinray.io>
To: notmuch@notmuchmail.org
Cc: Austin Ray <austin@austinray.io>
Subject: [PATCH] lib: load user config. in notmuch_database_open_verbose()
Date: Sat, 14 Aug 2021 15:36:47 -0400	[thread overview]
Message-ID: <20210814193647.3313589-1-austin@austinray.io> (raw)

Docstring for notmuch_database_open_verbose() states it calls
notmuch_database_open_with_config() with "config_path=NULL"; however,
the implementation uses an empty string. This results in libnotmuch
ignoring the user's configuration and may cause issues in downstream
library consumers.

Signed-off-by: Austin Ray <austin@austinray.io>

---

NeoMutt has an open bug[0] related to this. The user is using a separate
database and email directory so libnotmuch returns file paths rooted in
the database directory when calling notmuch_database_open_verbose(). If
calling notmuch_database_open_with_config() with "config_path=NULL",
libnotmuch returns the correct file paths.

[0] https://github.com/neomutt/neomutt/issues/3017
---
 lib/open.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/open.cc b/lib/open.cc
index 7b95c5b1..0d25ba72 100644
--- a/lib/open.cc
+++ b/lib/open.cc
@@ -36,7 +36,7 @@ notmuch_database_open_verbose (const char *path,
 			       notmuch_database_t **database,
 			       char **status_string)
 {
-    return notmuch_database_open_with_config (path, mode, "", NULL,
+    return notmuch_database_open_with_config (path, mode, NULL, NULL,
 					      database, status_string);
 }
 
-- 
2.31.1

             reply	other threads:[~2021-08-14 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14 19:36 Austin Ray [this message]
2021-08-14 19:56 ` [PATCH] lib: load user config. in notmuch_database_open_verbose() David Bremner
2021-08-14 20:48   ` Austin Ray
2021-08-14 21:22     ` David Bremner
2021-08-14 22:40       ` Austin Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210814193647.3313589-1-austin@austinray.io \
    --to=austin@austinray.io \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).