unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 21/25] lib: define _notmuch_query_from_sexp
Date: Sat, 17 Jul 2021 23:40:17 -0300	[thread overview]
Message-ID: <20210718024021.3850340-22-david@tethera.net> (raw)
In-Reply-To: <20210718024021.3850340-1-david@tethera.net>

This will be used in a following commit to provide the equivalant of
thread:{} syntax for s-expression queries.
---
 lib/parse-sexp.cc | 13 +++++--------
 lib/parse-sexp.h  | 14 ++++++++++++--
 lib/query.cc      | 23 ++++++++++++++++++++++-
 3 files changed, 39 insertions(+), 11 deletions(-)

diff --git a/lib/parse-sexp.cc b/lib/parse-sexp.cc
index c0d0b596..cfd503d9 100644
--- a/lib/parse-sexp.cc
+++ b/lib/parse-sexp.cc
@@ -1,5 +1,5 @@
 #include "database-private.h"
-#include "sexp.h"
+#include "parse-sexp.h"
 #include "parse-time-vrp.h"
 #include "query-fp.h"
 #include "regexp-fields.h"
@@ -81,9 +81,6 @@ static _sexp_keyword_t keywords[] =
     { }
 };
 
-static notmuch_status_t _sexp_to_xapian_query (notmuch_database_t *notmuch, const sexp_t *sx,
-					       Xapian::Query &output);
-
 static notmuch_status_t
 _sexp_combine_query (notmuch_database_t *notmuch,
 		     Xapian::Query::op operation,
@@ -102,7 +99,7 @@ _sexp_combine_query (notmuch_database_t *notmuch,
 	return NOTMUCH_STATUS_SUCCESS;
     }
 
-    status = _sexp_to_xapian_query (notmuch, sx, subquery);
+    status = _notmuch_sexp_to_xapian_query (notmuch, sx, subquery);
     if (status)
 	return status;
 
@@ -123,7 +120,7 @@ _notmuch_sexp_string_to_xapian_query (notmuch_database_t *notmuch, const char *q
     if (! sx)
 	return NOTMUCH_STATUS_BAD_QUERY_SYNTAX;
 
-    return _sexp_to_xapian_query (notmuch, sx, output);
+    return _notmuch_sexp_to_xapian_query (notmuch, sx, output);
 }
 
 static void
@@ -241,8 +238,8 @@ _sexp_parse_keywords (notmuch_database_t *notmuch, const char *prefix, const sex
  * element defining and operation, or as a special case the empty
  * list */
 
-static notmuch_status_t
-_sexp_to_xapian_query (notmuch_database_t *notmuch, const sexp_t *sx, Xapian::Query &output)
+notmuch_status_t
+_notmuch_sexp_to_xapian_query (notmuch_database_t *notmuch, const sexp_t *sx, Xapian::Query &output)
 {
 
     const _sexp_op_t *op;
diff --git a/lib/parse-sexp.h b/lib/parse-sexp.h
index a358bf26..eb78cbda 100644
--- a/lib/parse-sexp.h
+++ b/lib/parse-sexp.h
@@ -1,6 +1,16 @@
 #ifndef _PARSE_SEXP_H
 #define _PARSE_SEXP_H
 /* parse_sexp.cc */
-notmuch_status_t _notmuch_sexp_string_to_xapian_query (notmuch_database_t *notmuch, const
-						       char *querystr, Xapian::Query &output);
+#include <sexp.h>
+
+notmuch_status_t _notmuch_sexp_string_to_xapian_query (notmuch_database_t *notmuch,
+						       const char *querystr,
+						       Xapian::Query &output);
+
+notmuch_status_t _notmuch_sexp_to_xapian_query (notmuch_database_t *notmuch, const sexp_t *sx,
+						Xapian::Query &output);
+
+notmuch_status_t _notmuch_query_from_sexpr (notmuch_database_t *notmuch, const sexp_t *sexp,
+					    notmuch_query_t *&output);
+
 #endif
diff --git a/lib/query.cc b/lib/query.cc
index 0916860e..4ada3fe0 100644
--- a/lib/query.cc
+++ b/lib/query.cc
@@ -112,7 +112,10 @@ _notmuch_query_constructor (notmuch_database_t *notmuch,
 
     query->notmuch = notmuch;
 
-    query->query_string = talloc_strdup (query, query_string);
+    if (query_string)
+	query->query_string = talloc_strdup (query, query_string);
+    else
+	query->query_string = NULL;
 
     query->sort = NOTMUCH_SORT_NEWEST_FIRST;
 
@@ -193,6 +196,24 @@ _notmuch_query_ensure_parsed_xapian (notmuch_query_t *query)
     return NOTMUCH_STATUS_SUCCESS;
 }
 
+notmuch_status_t
+_notmuch_query_from_sexpr (notmuch_database_t *notmuch, const sexp_t *sexp, notmuch_query_t *&output)
+{
+    notmuch_status_t status;
+    notmuch_query_t *query = _notmuch_query_constructor (notmuch, NULL);
+
+    status = _notmuch_sexp_to_xapian_query (notmuch, sexp, query->xapian_query);
+    if (status)
+	return status;
+
+    query->syntax = NOTMUCH_QUERY_SYNTAX_SEXPR;
+    query->parsed = true;
+
+    output = query;
+
+    return NOTMUCH_STATUS_SUCCESS;
+}
+
 static notmuch_status_t
 _notmuch_query_ensure_parsed_sexpr (notmuch_query_t *query)
 {
-- 
2.30.2

  parent reply	other threads:[~2021-07-18  2:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-18  2:39 v2 sexpr parser David Bremner
2021-07-18  2:39 ` [PATCH 01/25] configure: optional library sfsexp David Bremner
2021-07-18  2:39 ` [PATCH 02/25] lib: split notmuch_query_create David Bremner
2021-07-18  2:39 ` [PATCH 03/25] lib: define notmuch_query_create_sexpr David Bremner
2021-07-18  2:40 ` [PATCH 04/25] CLI/search+address: support sexpr queries David Bremner
2021-07-18  2:40 ` [PATCH 05/25] lib: add new status code for query syntax errors David Bremner
2021-07-18  2:40 ` [PATCH 06/25] lib/parse-sexp: parse 'and', 'not', 'or' David Bremner
2021-07-18  2:40 ` [PATCH 07/25] lib/parse-sexp: parse 'subject' David Bremner
2021-07-18  2:40 ` [PATCH 08/25] lib/parse-sexp: split terms in phrase mode David Bremner
2021-07-18  2:40 ` [PATCH 09/25] lib/parse-sexp: handle most fields David Bremner
2021-07-18  2:40 ` [PATCH 10/25] lib/parse-sexp: handle unprefixed terms David Bremner
2021-07-18  2:40 ` [PATCH 11/25] lib: factor out date to query conversion David Bremner
2021-07-18  2:40 ` [PATCH 12/25] lib/parse-sexp: parse date fields David Bremner
2021-07-18  2:40 ` [PATCH 13/25] lib: factor out expansion of saved queries David Bremner
2021-07-18  2:40 ` [PATCH 14/25] lib/parse-sexp: handle " David Bremner
2021-07-18  2:40 ` [PATCH 15/25] lib/parse-sexp: add keyword arguments for fields David Bremner
2021-07-18  2:40 ` [PATCH 16/25] lib/parse-sexp: initial support for wildcard queries David Bremner
2021-07-18  2:40 ` [PATCH 17/25] lib/query: generalize exclude handling to s-expression queries David Bremner
2021-07-18  2:40 ` [PATCH 18/25] lib: factor out query construction from regexp David Bremner
2021-07-18  2:40 ` [PATCH 19/25] lib/parse-sexp: add support for regexp fields David Bremner
2021-07-18  2:40 ` [PATCH 20/25] lib/thread-fp: factor out query expansion David Bremner
2021-07-18  2:40 ` David Bremner [this message]
2021-07-18  2:40 ` [PATCH 22/25] lib: generate actual Xapian query for "*" and "" David Bremner
2021-07-18  2:40 ` [PATCH 23/25] lib/parse-sexp: support thread subqueries David Bremner
2021-07-18  2:40 ` [PATCH 24/25] lib/parse-sexp: support infix subqueries David Bremner
2021-07-18  2:40 ` [PATCH 25/25] lib/parse-sexp: parse user headers David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210718024021.3850340-22-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).