From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Early preview of s-expression based query parser
Date: Tue, 13 Jul 2021 21:02:28 -0300 [thread overview]
Message-ID: <20210714000239.804384-1-david@tethera.net> (raw)
I have no plans to replace or deprecate the Xapian query parser based
syntax. On the other hand, having full control over the parser makes
it easier to support certain features. As an example, once the basic
parser is in place, the last patch in the series adds prefixed
wildcards with about 10 lines of code.
S-expressions are also hand for constructing queries from other
queries, which is not really well supported by the Xapian query
parser. So it should also make it possible to fix a few bugs resulting
from gluing strings together and hoping the result is a valid query.
There are quite a few missing features here, and a couple known bugs
(the treatment of body: queries is probably mostly broken in the new
parser). Finally, when I next re-roll the series I will probably push
the error handling earlier in the series.
Feedback of any kind is welcome, but particularly on UI / UX
issues. You can get a pretty good idea of the supported syntax by
looking at the tests.
It does add a dependency on sfsexp, a C s-expression parsing
library. It's not heavyweight, but it's also not available very many
places yet (other than on github). Upstream has been great about
merging a few changes for me. One question mark is UTF8 support; it
seems to work OK, but upstream is in the process of documenting the
support status.
next reply other threads:[~2021-07-14 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 0:02 David Bremner [this message]
2021-07-14 0:02 ` [PATCH 01/11] configure: optional library sfsexp David Bremner
2021-07-14 0:02 ` [PATCH 02/11] lib: split notmuch_query_create David Bremner
2021-07-14 0:02 ` [PATCH 03/11] lib: define notmuch_query_create_sexpr David Bremner
2021-07-14 0:02 ` [PATCH 04/11] CLI/search+address: support sexpr queries David Bremner
2021-07-14 0:02 ` [PATCH 05/11] lib/parse-sexp: parse 'and', 'not', 'or' David Bremner
2021-07-14 0:02 ` [PATCH 06/11] lib/parse-sexp: parse 'subject' David Bremner
2021-07-14 0:02 ` [PATCH 07/11] lib/parse-sexp: split terms in phrase mode David Bremner
2021-07-14 0:02 ` [PATCH 08/11] lib/parse-sexp: handle most fields David Bremner
2021-07-14 0:02 ` [PATCH 09/11] lib/parse-sexp: add error handling to internal API David Bremner
2021-07-14 0:02 ` [PATCH 10/11] lib/parse-sexp: add keyword arguments for fields David Bremner
2021-07-14 0:02 ` [PATCH 11/11] lib/parse-sexp: initial support for wildcard queries David Bremner
2021-07-16 14:00 ` Early preview of s-expression based query parser Hannu Hartikainen
2021-07-18 19:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714000239.804384-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).