From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gOBDGqQI5WCmfAEAgWs5BA (envelope-from ) for ; Wed, 07 Jul 2021 03:51:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MP73FaQI5WAdGwAAB5/wlQ (envelope-from ) for ; Wed, 07 Jul 2021 01:51:32 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA11EC529 for ; Wed, 7 Jul 2021 03:51:31 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 945A6290CF; Tue, 6 Jul 2021 21:51:28 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id A800927D92 for ; Tue, 6 Jul 2021 21:51:25 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 828BC5FD21; Tue, 6 Jul 2021 21:51:25 -0400 (EDT) Received: (nullmailer pid 65360 invoked by uid 1000); Wed, 07 Jul 2021 01:51:24 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH] emacs: remove useless lexically bound variable Date: Tue, 6 Jul 2021 22:51:08 -0300 Message-Id: <20210707015108.65309-1-david@tethera.net> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Message-ID-Hash: 3ZXIMBMY2T5YDRYMAXYJHST4L5UQPV6E X-Message-ID-Hash: 3ZXIMBMY2T5YDRYMAXYJHST4L5UQPV6E X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625622692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Yex3MBzvOWKLmIAOr7JyiCZWIIJAuDM4WruXZVmL1i8=; b=YZUk5nVhFwxjsm6BsD78W2rwXr04rFFqXX9mYdlDeSvrqklGV0sND2JGyGNgh8W3px77SB duxKK4KEiWuIy4IzIRNjcwzcJ05uwchWY3ZI9o9jzOCDhHaUxl+v6Cx8i86SqZt7xYXjbZ sxiM9qWoUfI/ef6J+JTlmmp1WkolrG9aIvUtd5QJZLiwBvskmJQSJBV1/XWLTVWZbtv+Df ltLVj/BrewCTAgG+XU7lfBVrJHblf4DE2/MywbEzV6E48HYWhUgxTXEdmodtqe3d/Nesit jby7u7PdPk3jO7mPYdBrsyQGHskM2ATtsDWhDC9ucXfhQ+1plzQTgqvwUvD7bA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625622692; a=rsa-sha256; cv=none; b=s6HtD8L7MDLIN+lxBx7WasLnb1uM8CyljfmHJhiiyOCk34qOMjjbT12pw3tVogfQedSRTk XhChsFgeEAPA5bVDl9mfN24RNoTWOnjpQHil3yn5wdfM19pkY+3XhDZ6/4CqNefvCiqXyl SGM/+IqkPzkEg90F73WBOnKlrxNSFMcIXqFZUWRI36ApZSNMnZMPSO28EgoenLLsFoY+xb tIaw0FZH7l/CMCDU8pzdzqIyKkvi5oWuIWQO/1+nKq2jxU2EmnPk4b6V+SdRG2Ci+OgwnR s3iXf9IMZh43vJ/NFj/v+SR4h0vQYcWxsit+29eQfPcP1BRFM+AoqIRwLKUKKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.06 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: EA11EC529 X-Spam-Score: -1.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZifXRKHq/5GI A let binding without a value is just an obfuscated way of saying nil, especially if you are not going to mutate the variable. --- emacs/notmuch-tree.el | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b288c05d..eb7ea941 100644 --- a/emacs/notmuch-tree.el +++ b/emacs/notmuch-tree.el @@ -1001,10 +1001,9 @@ message together with all its descendents." (defun notmuch-tree-insert-forest-thread (forest-thread) "Insert a single complete thread." - (let (tree-status) - ;; Reset at the start of each main thread. - (setq notmuch-tree-previous-subject nil) - (notmuch-tree-insert-thread forest-thread 0 tree-status))) + ;; Reset at the start of each main thread. + (setq notmuch-tree-previous-subject nil) + (notmuch-tree-insert-thread forest-thread 0 nil)) (defun notmuch-tree-insert-forest (forest) "Insert a forest of threads. -- 2.30.2