unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: [PATCH 3/3] emacs: dynamically bind gnus-newsgroup-charset
Date: Sun,  4 Jul 2021 10:16:39 -0300	[thread overview]
Message-ID: <20210704131639.3400795-4-david@tethera.net> (raw)
In-Reply-To: <20210704131639.3400795-1-david@tethera.net>

This avoids requiring gnus-sum, which is currently where this variable
is defined.
---
 emacs/notmuch-lib.el    | 3 ++-
 test/T450-emacs-show.sh | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 8ca416d4..37fb4018 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -693,7 +693,8 @@ current buffer, if possible."
 	    (insert (notmuch-get-bodypart-binary msg part process-crypto)))
 	  (when (mm-inlinable-p handle)
 	    (set-buffer display-buffer)
-	    (mm-display-part handle)
+	    (notmuch-dlet ((gnus-newsgroup-charset nil))
+	      (mm-display-part handle))
 	    ;; restore major mode if changed by gnus
 	    (notmuch-show-mode)
 	    t))))))
diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
index 75a52640..7a731ac7 100755
--- a/test/T450-emacs-show.sh
+++ b/test/T450-emacs-show.sh
@@ -220,7 +220,6 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org")
 test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT
 
 test_begin_subtest "show encrypted rfc822 message"
-test_subtest_known_broken
 test_emacs '(notmuch-show "id:encrypted-rfc822-attachment@crypto.notmuchmail.org")
             (test-visible-output)'
 count=$(fgrep -c '!!!' OUTPUT)
-- 
2.30.2

  parent reply	other threads:[~2021-07-04 13:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03 20:11 [PATCH 1/2] test/crypto: test message with rfc822 attachment David Bremner
2021-07-03 20:11 ` [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts David Bremner
2021-07-04  9:24   ` Tomi Ollila
2021-07-04 13:32     ` David Bremner
2021-08-30 23:32       ` David Bremner
2021-07-04 13:16   ` WIP fixes for rfc822/attachement display David Bremner
2021-07-04 13:16     ` [PATCH 1/3] emacs: forcibly set notmuch-show-mode after delegating inlining David Bremner
2021-07-04 13:16     ` [PATCH 2/3] emacs: don't inline message/rfc822 parts without content David Bremner
2021-08-30 23:37       ` David Bremner
2021-07-04 13:16     ` David Bremner [this message]
2021-07-06 15:49     ` WIP fixes for rfc822/attachement display David Bremner
2021-07-09  0:35       ` Antoine Beaupré
2021-07-09 10:23         ` David Bremner
2021-07-09 23:36           ` Antoine Beaupré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210704131639.3400795-4-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).