unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts
Date: Sat,  3 Jul 2021 17:11:31 -0300	[thread overview]
Message-ID: <20210703201131.3184165-2-david@tethera.net> (raw)
In-Reply-To: <20210703201131.3184165-1-david@tethera.net>

There are at least 3 bugs present.

1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822
parts will have a ":content" property, but that turns out not to be
the case.

2) something deep in gnus wants gnus-newsgroup-charset, but that is
defined in gnus-sum, which is not loaded by default.

3) If gnus-sum is loaded, then the display of the message/rfc822 part
succeeds, but the buffer gets put into gnus-article-mode, which means
that, inter alia, notmuch text properties and keybindings get wiped.
---
 test/T450-emacs-show.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
index 9d08d2cc..bf7c1fe0 100755
--- a/test/T450-emacs-show.sh
+++ b/test/T450-emacs-show.sh
@@ -219,6 +219,13 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org")
             (test-visible-output)'
 test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT
 
+test_begin_subtest "show encrypted rfc822 message"
+test_subtest_known_broken
+test_emacs '(notmuch-show "id:encrypted-rfc822-attachment@crypto.notmuchmail.org")
+            (test-visible-output)'
+fgrep '!!!' OUTPUT > OUTPUT.err
+test_expect_equal_file /dev/null OUTPUT.err
+
 test_begin_subtest "show undecryptable message"
 test_emacs '(notmuch-show "id:simple-encrypted@crypto.notmuchmail.org")
             (test-visible-output)'
-- 
2.30.2

  reply	other threads:[~2021-07-03 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03 20:11 [PATCH 1/2] test/crypto: test message with rfc822 attachment David Bremner
2021-07-03 20:11 ` David Bremner [this message]
2021-07-04  9:24   ` [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts Tomi Ollila
2021-07-04 13:32     ` David Bremner
2021-08-30 23:32       ` David Bremner
2021-07-04 13:16   ` WIP fixes for rfc822/attachement display David Bremner
2021-07-04 13:16     ` [PATCH 1/3] emacs: forcibly set notmuch-show-mode after delegating inlining David Bremner
2021-07-04 13:16     ` [PATCH 2/3] emacs: don't inline message/rfc822 parts without content David Bremner
2021-08-30 23:37       ` David Bremner
2021-07-04 13:16     ` [PATCH 3/3] emacs: dynamically bind gnus-newsgroup-charset David Bremner
2021-07-06 15:49     ` WIP fixes for rfc822/attachement display David Bremner
2021-07-09  0:35       ` Antoine Beaupré
2021-07-09 10:23         ` David Bremner
2021-07-09 23:36           ` Antoine Beaupré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210703201131.3184165-2-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).