From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kHm6GM5v22DtQQAAgWs5BA (envelope-from ) for ; Tue, 29 Jun 2021 21:09:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sIVgFM5v22B/DAAA1q6Kng (envelope-from ) for ; Tue, 29 Jun 2021 19:09:02 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2B7B25BD3 for ; Tue, 29 Jun 2021 21:09:01 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B8CCF2912C; Tue, 29 Jun 2021 15:08:50 -0400 (EDT) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6E98F2911D for ; Tue, 29 Jun 2021 15:08:45 -0400 (EDT) Received: by mail-ot1-x329.google.com with SMTP id d21-20020a9d72d50000b02904604cda7e66so22004044otk.7 for ; Tue, 29 Jun 2021 12:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7xDOERmOSrPxEUco4lI9BmI2Wy1z4FjFHIBkK4BEHPg=; b=B7en00yAb1H0MLO/g0I4//mHMmpVEEQjqxkoOcXJGvzPbK1eQNNQ2KSjAcp1D70rJO GjifhGvlJY7PdUICZEwRX6ggIOcleSoHgXWgF1juuakVTlJeX1VDuyIBvFcCpQGLJ96d UUzaqAxxwGgZRcBCpX46LujFoSwJpoNsoaXtsS3wWNpK2lFw2zgfAbIcwNTEENksYY1W 59RJRs7saFGMX0eWVPE4s2Tz/u8lcwKeEX+PCm0XayBZFCcqeB4x6JA70xkK8fYsj2Nd FnCcvIWfoRWRecJU81nrrtDQRz5enZFEe/jDLifiNQ1IzNPe9g6wxafeempGN05bGE96 lfoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7xDOERmOSrPxEUco4lI9BmI2Wy1z4FjFHIBkK4BEHPg=; b=AxoCeu9Z3l/E9ubYhh/WKvTAUaJU3N+4DgdlIF8tZuh/Q9U1aaIA09stTb93Wjfraj 7JntpF4fDGLlL/3btVPdqtNP6K5k3tnDKvMntiSkOdyAuPlFxDPAkDf0QYHyBGseMGLg /hctOPim1tdmYeQPghye5pGXErLRE0aaui1gKkUMTcFD6mFaDDOYq/zPGw0pgF2c+jO3 IQ+uHLsqrUqBUwIhgxuXIlbNJnWQWDPZnCABDNo1ZSOTDY/c2gASSOFrelmSttOkU62M g3bUbRNznDIuYp9q0Z2PH2frn8M+KlW48PgtbSDQfU5u+cjVmup3ytm7GBmpUXaUy7io Yb3A== X-Gm-Message-State: AOAM533lJd085DPqGKshpag3p51s45uMvdEuWPczXhHArdWpTy3QouEB rTdbLpYmMxZ0VvogLF7LMabGAOZ7wH30xw== X-Google-Smtp-Source: ABdhPJyxICSGp+XXRb2r/Cqe1D256Qm63OVtJT4jm7jks6uMMdOWv9P/Ptnoi59ZjcisY4N4aKMX3w== X-Received: by 2002:a05:6830:90b:: with SMTP id v11mr5788840ott.3.1624993724652; Tue, 29 Jun 2021 12:08:44 -0700 (PDT) Received: from localhost (fixed-187-189-165-231.totalplay.net. [187.189.165.231]) by smtp.gmail.com with ESMTPSA id x4sm730683oia.40.2021.06.29.12.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 12:08:44 -0700 (PDT) From: Felipe Contreras To: notmuch@notmuchmail.org Cc: David Bremner , Felipe Contreras Subject: [PATCH v2 3/3] ruby: make db.config return an enumerator Date: Tue, 29 Jun 2021 14:08:35 -0500 Message-Id: <20210629190835.19381-4-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210629190835.19381-1-felipe.contreras@gmail.com> References: <20210629190835.19381-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Message-ID-Hash: 3AGM5HV5IZ54Q5ODVTXS4RC76Y3R2DTE X-Message-ID-Hash: 3AGM5HV5IZ54Q5ODVTXS4RC76Y3R2DTE X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624993742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cbArNpj4RKlCdkPML5ZqE3/5bWTtWPMM1Kbn7tmWx9k=; b=ihZdV8LCwMltqXZaKojZYlkdKMetwqjakaomp7LQxu5zb/SpxDKgM09nwNghQ5izYNelO7 MhyY3Sxj+54BTtxeA76tnALQhqiJWo/l+ZMrugoa2M8dLsMAKyj8YeCabxrKnY8f/xTaNO Pm4s04D/Qgur+0lCK8HNkzVgN8Y/D4WkOOuofMbz1hcma5g2tC/Xsxrz4mKNIBhXXydPgg bGpsZ6dQrtGGVufkwIq4H40p40JsWqkRiaaXWekm7u6V4Kw91KENGEs7KZcE6zxljpKPKT wRMSI5zNEzdJCUHPPKqhqwZjTZaqmNtJXEMJt9n9nmwZ36xx+Gb11kBjxpXytw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624993742; a=rsa-sha256; cv=none; b=IkdXz2Ib0yImusoZdx5k+YrieAi1ofipax9w561jdlnjGOjp3wdsaX2E3BlZoaMZljDkX7 pfnFNXJxqYVYAo5QEOfABx1VaDxia1fwaxcVUQQ+XwrBjuLl3SPwPXi5Fmm7tVWb2aWsPT QcSJCeJNQQft2yJdasEr1NDOq+1fgNhra0Cga8RV4WRR1bgQouhFOOqQ7NCqmlGySdgGLy /6/XAGoMEebTZFxIKEVwoWVP42LgfDtZyquJnMkXT1mDyfN/HTGQ8695u3X/UxdEoiAE6X 44p7/PqyfbOFw7ab/xhUZIssNcx/dzkffk7pliFlWRxBLSPZ4BtTskmQZ8WB0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=B7en00yA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=B7en00yA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: F2B7B25BD3 X-Spam-Score: -0.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: tB51ST5XXTsS Currently db.config requires a block to work: db.config { |k, v| puts '%s=%s' % [k, v] } If you try to use it without a block you, get an error like: in `config': no block given (LocalJumpError) In Ruby most methods should return an Enumerator if no block is given, like: (1..10).each => # This allows us to do: db.config.to_a db.config.to_h db.config.each { |k, v| ... } And of course what is already possible: db.config { |k, v| ... } Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index 571f7e24..926b0985 100644 --- a/bindings/ruby/database.c +++ b/bindings/ruby/database.c @@ -535,6 +535,8 @@ notmuch_rb_database_config (int argc, VALUE *argv, VALUE self) notmuch_config_pairs_t *list; const char *cprefix; + RETURN_ENUMERATOR(self, argc, argv); + Data_Get_Notmuch_Database (self, db); rb_scan_args (argc, argv, "01", &prefix); -- 2.32.0