From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 2/2] lib/config: fix memory leak
Date: Fri, 18 Jun 2021 21:59:44 -0300 [thread overview]
Message-ID: <20210619005944.2267177-2-david@tethera.net> (raw)
In-Reply-To: <20210619005944.2267177-1-david@tethera.net>
This commit fixes a small memory leak (per iterator restart) by
actually using the talloc context intended to be blown away on
restart.
---
lib/config.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/config.cc b/lib/config.cc
index 0ec66372..368ed669 100644
--- a/lib/config.cc
+++ b/lib/config.cc
@@ -318,7 +318,7 @@ notmuch_config_values_valid (notmuch_config_values_t *values)
const char *
notmuch_config_values_get (notmuch_config_values_t *values)
{
- return talloc_strndup (values, values->iterator, values->tok_len);
+ return talloc_strndup (values->children, values->iterator, values->tok_len);
}
void
--
2.30.2
next prev parent reply other threads:[~2021-06-19 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 0:59 [PATCH 1/2] lib: write talloc report in notmuch_database_destroy David Bremner
2021-06-19 0:59 ` David Bremner [this message]
2021-06-25 12:46 ` [PATCH 2/2] lib/config: fix memory leak David Bremner
2021-06-19 13:55 ` [PATCH 1/2] lib: write talloc report in notmuch_database_destroy David Bremner
2021-06-25 12:45 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619005944.2267177-2-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).