From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kAAXOtoUuGCaBwEAgWs5BA (envelope-from ) for ; Thu, 03 Jun 2021 01:31:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WLEgNdoUuGAuOwAA1q6Kng (envelope-from ) for ; Wed, 02 Jun 2021 23:31:38 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64AAD109AC for ; Thu, 3 Jun 2021 01:31:38 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 070F92B232; Wed, 2 Jun 2021 19:31:26 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 4C3C72B213 for ; Wed, 2 Jun 2021 19:31:20 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 0B7D95FD25; Wed, 2 Jun 2021 19:31:18 -0400 (EDT) Received: (nullmailer pid 858594 invoked by uid 1000); Wed, 02 Jun 2021 23:31:16 -0000 From: David Bremner To: Tomi Ollila , David Bremner , Alan Schmitt , notmuch Subject: First attempt at a fix for single message display deep in thread Date: Wed, 2 Jun 2021 20:31:06 -0300 Message-Id: <20210602233108.855449-1-david@tethera.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Message-ID-Hash: 5FCFKOYNT66MMXFB4WMKIVBDZIK5DKO5 X-Message-ID-Hash: 5FCFKOYNT66MMXFB4WMKIVBDZIK5DKO5 X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622676698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qrBoImHHzfdG+t+qeKfJgjYWzyR4VHejK/O5p/r5UF8=; b=h5HuRpKKTILPlX+jXdVAQ/4yRi6Kf3c5w8p/tW0t/2xkKjPUy8+gnt/JZNgQ2MKCQX7wia V2vAPDamp9oQjRFZ5nybhU1UYl9tKG2IJFVWWIqMIyixq67xec1UI0NZAEbBuvp4JAP5Rv g44rht6EsO5QfAIM4ebZygw3qYLtJzaSIwpLrbdR1sMWU3IFqIH8H6KXTdTtCrHAdWWJVP FEfegah1yJEv9RUG4BcTMfeebFX1BVcidK2FNuztIqSHOZL52f8zG4kewTYXhmE1KIHiM2 9sKEZFdavUlyRyee/HrnS7BNjLrN5mqsQrgB3aD76JYkUhrLSfxzdjFjCz0+pQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622676698; a=rsa-sha256; cv=none; b=g11b3vuh9GU+r0UwVMmeScEYIyJQPc4l8/iwb4BqLq0FY+GKccAUNrR3iGlNI5No5WO0A2 u39ttkBMwZaECFJ268uRU9EsE3oBnkC1yNFcR1UXiBNcJbEnbHjGabRM3xR58GaiSNO8wk bOQp8pvW1xLt4sNWlkBkY27EvwbFQQONJUWhBa2aOquolo8PDH2NAB3wjREYGTcUqp4JYY lY3/NEz5U5A0ZOZb5ZDOTZaFggfC0s/KPx8PMSIIZgwR3tRge0TmYLbrz0bCDaD034FJtk 2X9Q8GP2NhmkjS2V0QF92v6MuQS8lKU+MHYWs+cL4oa0AOTV22i4Id69l3IGGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 64AAD109AC X-Spam-Score: -1.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: xTN536qN6azO Alan, if you can test this, it would be great. You just need a copy of the source, and to apply the following two patches. You can use devel/try-emacs-mua to run the patched emacs front-end. The idea is that the notmuch-tree UI should be the same, but just not crash on displaying a message from large threads. If that still crashes (perhaps displaying the tree), please try (let ((notmuch-show-single-message t)) (notmuch show "id:foo")) I am curious if people thing the unthreaded view should work the same way, only displaying a single message. In the mean time I will try to write a test for large threads in emacs. I don't especially love the solution of adding yet another dynamically bound parameter, but I guess we can clean it up after we have something working. One option would be to make a seperate function for use showing a single message.