unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	David Bremner <david@tethera.net>,
	Alan Schmitt <alan.schmitt@polytechnique.org>,
	notmuch <notmuch@notmuchmail.org>
Subject: First attempt at a fix for single message display deep in thread
Date: Wed,  2 Jun 2021 20:31:06 -0300	[thread overview]
Message-ID: <20210602233108.855449-1-david@tethera.net> (raw)
In-Reply-To: <m2lf7sm5vh.fsf@guru.guru-group.fi>

Alan, if you can test this, it would be great. You just need a copy of
the source, and to apply the following two patches. You can use
devel/try-emacs-mua to run the patched emacs front-end.

The idea is that the notmuch-tree UI should be the same, but just not
crash on displaying a message from large threads. If that still
crashes (perhaps displaying the tree), please try

(let ((notmuch-show-single-message t))
   (notmuch show "id:foo"))
   
I am curious if people thing the unthreaded view should work the same
way, only displaying a single message.

In the mean time I will try to write a test for large threads in
emacs.

I don't especially love the solution of adding yet another dynamically
bound parameter, but I guess we can clean it up after we have
something working. One option would be to make a seperate function for
use showing a single message.

  reply	other threads:[~2021-06-02 23:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 10:10 show a single message in a huge thread alan.schmitt
2021-05-28 12:37 ` David Bremner
2021-05-28 14:16   ` Alan Schmitt
2021-06-01  6:57     ` Alan Schmitt
2021-06-01 18:33       ` David Bremner
2021-06-01 18:48         ` Jameson Graef Rollins
2021-06-02  6:46         ` Alan Schmitt
2021-06-02 12:18           ` David Bremner
2021-06-02 16:02             ` David Bremner
2021-06-02 19:19               ` Tomi Ollila
2021-06-02 23:31                 ` David Bremner [this message]
2021-06-02 23:31                   ` [PATCH 1/2] emacs/show: add parameter notmuch-show-single-message David Bremner
2021-06-02 23:31                   ` [PATCH 2/2] emacs/tree: use notmuch-show-single-message David Bremner
2021-06-03  7:53                   ` First attempt at a fix for single message display deep in thread Alan Schmitt
2021-06-03  7:55             ` show a single message in a huge thread Alan Schmitt
2021-06-11 16:45               ` Jonathan Wilner
2021-06-12 20:39                 ` Tomi Ollila
2021-05-28 16:01 ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602233108.855449-1-david@tethera.net \
    --to=david@tethera.net \
    --cc=alan.schmitt@polytechnique.org \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).