unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH v2 0/2] ruby: improve db.query
@ 2021-05-24  2:19 Felipe Contreras
  2021-05-24  2:19 ` [PATCH v2 1/2] ruby: add keyword arguments to db.query Felipe Contreras
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Felipe Contreras @ 2021-05-24  2:19 UTC (permalink / raw)
  To: notmuch; +Cc: Ludovic LANGE, Stefano Zacchiroli

I find it a bit annoying to have to modify the query object to add
options when Notmuch::Database.query() can do that just fine.

This series also adds a mapping to the notmuch_exclude_t enum in order
to be able to specify NOTMUCH_EXCLUDE_ALL and others.

Nothing changed from v1 except rebased on master of May 23.

Felipe Contreras (2):
  ruby: add keyword arguments to db.query
  test: ruby: simplify basic tests

 bindings/ruby/database.c | 47 +++++++++++++++++++++++++++++++++++++---
 bindings/ruby/defs.h     |  2 +-
 bindings/ruby/init.c     |  2 +-
 test/T395-ruby.sh        | 30 ++++++++++++++++++-------
 4 files changed, 68 insertions(+), 13 deletions(-)

Range-diff against v1:
1:  8cc8cedd < -:  -------- ruby: use notmuch_exclude_t enum
2:  70938802 ! 1:  ec8b5d1a ruby: add keyword arguments to db.query
    @@ bindings/ruby/database.c: notmuch_rb_database_query_create (VALUE self, VALUE qs
     +	}
     +    }
     +
    -     return Data_Wrap_Struct (notmuch_rb_cQuery, NULL, NULL, query);
    +     return Data_Wrap_Notmuch_Object (notmuch_rb_cQuery, &notmuch_rb_query_type, query);
      }
     
      ## bindings/ruby/defs.h ##
3:  26519f68 = 2:  29c15ec1 test: ruby: simplify basic tests
-- 
2.32.0.rc0

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-28  7:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24  2:19 [PATCH v2 0/2] ruby: improve db.query Felipe Contreras
2021-05-24  2:19 ` [PATCH v2 1/2] ruby: add keyword arguments to db.query Felipe Contreras
2021-06-27 17:18   ` David Bremner
2021-06-28  7:46     ` Felipe Contreras
2021-05-24  2:19 ` [PATCH v2 2/2] test: ruby: simplify basic tests Felipe Contreras
2021-06-04  6:08 ` [PATCH v2 0/2] ruby: improve db.query Felipe Contreras

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).