[PATCH] ruby: improve compilation with CFLAGS

[PATCH] ruby: improve compilation with CFLAGS

[Felipe Contreras]

The ruby MakeMakefile generates a makefile that is suboptimal, which has
CFLAGS like this:

  CFLAGS   = $(CCDLFLAGS) -march=x86-64 -mtune=generic \
    -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG)

This works as long as the user doesn't modify the Makefile.

Certain flags (namely -fPIC) need to be present regardless of what
CFLAGS are specified.

The Makefile should have done this instead:

  CFLAGS = -march=x86-64 -mtune=generic -O2
  override CFLAGS += $(CCDLFLAGS) -pipe -fno-plt -fPIC $(ARCH_FLAG)

Unfortunately they didn't, so we need to workaround their lack of
foresight.

We can simply add the necessary flags in the parent Makefile so everyone
is happy.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 bindings/Makefile.local | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bindings/Makefile.local b/bindings/Makefile.local
index bc960bbc..3672e69f 100644
--- a/bindings/Makefile.local
+++ b/bindings/Makefile.local
@@ -10,7 +10,7 @@ ifeq ($(HAVE_RUBY_DEV),1)
 		LIBNOTMUCH="../../lib/$(LINKER_NAME)" \
 		NOTMUCH_SRCDIR='$(NOTMUCH_SRCDIR)' \
 		$(RUBY) extconf.rb --vendor
-	$(MAKE) -C $(dir)/ruby
+	$(MAKE) -C $(dir)/ruby CFLAGS="$(CFLAGS) -pipe -fno-plt -fPIC"
 endif
 
 python-cffi-bindings: lib/$(LINKER_NAME)
-- 
2.31.1

Re: [PATCH] ruby: improve compilation with CFLAGS

[Felipe Contreras]

On Mon, May 17, 2021 at 12:48 AM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
> The ruby MakeMakefile generates a makefile that is suboptimal, which has
> CFLAGS like this:
>
>   CFLAGS   = $(CCDLFLAGS) -march=x86-64 -mtune=generic \
>     -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG)
>
> This works as long as the user doesn't modify the Makefile.

Great... doesn't modify the CFLAGS.

-- 
Felipe Contreras

Re: [PATCH] ruby: improve compilation with CFLAGS

[David Bremner]

Felipe Contreras <felipe.contreras@gmail.com> writes:

> The ruby MakeMakefile generates a makefile that is suboptimal, which has
> CFLAGS like this:
>
>   CFLAGS   = $(CCDLFLAGS) -march=x86-64 -mtune=generic \
>     -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG)

Ruby 2.7 doesn't seem to add -fno-plt, so this would be a change for
some people building the ruby bindings. The flag is available from gcc
6.x (2016). For clang I guess it is 2017ish. If anyone thinks this is
too recent of a toolchain dependence, now is your chance to object.

d

Re: [PATCH] ruby: improve compilation with CFLAGS

[David Bremner]

David Bremner <david@tethera.net> writes:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> The ruby MakeMakefile generates a makefile that is suboptimal, which has
>> CFLAGS like this:
>>
>>   CFLAGS   = $(CCDLFLAGS) -march=x86-64 -mtune=generic \
>>     -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG)
>
> Ruby 2.7 doesn't seem to add -fno-plt, so this would be a change for
> some people building the ruby bindings. The flag is available from gcc
> 6.x (2016). For clang I guess it is 2017ish. If anyone thinks this is
> too recent of a toolchain dependence, now is your chance to object.

Nobody complained, so I applied this to master.

d