unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH] perf-test/T00-new: fix backup creation.
Date: Sat,  8 May 2021 10:57:35 -0300	[thread overview]
Message-ID: <20210508135735.3548187-1-david@tethera.net> (raw)

"xargs tar cf backup.tar < $manifest" recreates the tar file with each
"batch" execed by xargs. In general this results in only a fraction of
the desired files being backed up.
---

I'm not sure if this is worth including in the point release: both the
risk and the benefit are relatively low since breaking the performance suite
probably mainly annoys me.

 performance-test/T00-new.sh | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/performance-test/T00-new.sh b/performance-test/T00-new.sh
index 53de1c27..de260b2d 100755
--- a/performance-test/T00-new.sh
+++ b/performance-test/T00-new.sh
@@ -5,16 +5,16 @@ test_description='notmuch new'
 . $(dirname "$0")/perf-test-lib.sh || exit 1
 
 uncache_database
-
 time_start
 
+manifest=$(mktemp manifestXXXXXX)
+find mail -type f ! -path 'mail/.notmuch/*' | sed -n '1~4 p' > $manifest
+xargs tar uf backup.tar < $manifest
+
 for i in $(seq 2 6); do
     time_run "notmuch new #$i" 'notmuch new'
 done
 
-manifest=$(mktemp manifestXXXXXX)
-
-find mail -type f ! -path 'mail/.notmuch/*' | sed -n '1~4 p' > $manifest
 # arithmetic context is to eat extra whitespace on e.g. some BSDs
 count=$((`wc -l < $manifest`))
 
@@ -26,8 +26,6 @@ perl -nle 'rename "$_.renamed", $_' $manifest
 
 time_run "new ($count mv back)" 'notmuch new'
 
-xargs tar cf backup.tar < $manifest
-
 perl -nle 'unlink $_; unlink $_.copy' $manifest
 
 time_run "new ($count rm)" 'notmuch new'
-- 
2.30.2

             reply	other threads:[~2021-05-08 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 13:57 David Bremner [this message]
2021-05-19 11:57 ` [PATCH] perf-test/T00-new: fix backup creation David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210508135735.3548187-1-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).