From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0r.migadu.com with LMTPS id 4MmVELdCjWC+YgEALuJCtg (envelope-from ) for ; Sat, 01 May 2021 13:59:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IFJeDLdCjWDhPAAA1q6Kng (envelope-from ) for ; Sat, 01 May 2021 11:59:51 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D7DDE1A5D7 for ; Sat, 1 May 2021 13:59:50 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DFBCC2758D; Sat, 1 May 2021 07:59:42 -0400 (EDT) Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by mail.notmuchmail.org (Postfix) with ESMTPS id B43E0271EA for ; Sat, 1 May 2021 07:59:32 -0400 (EDT) Received: by mail-oi1-x22b.google.com with SMTP id i26so828910oii.3 for ; Sat, 01 May 2021 04:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccIIBRUD0FOaJe5AW9sIvP1QuNd2dt4C7OK6LTDW8QY=; b=GUazO8cO0qPSlWFfD2C5oqd8S8EpwVg0la3eSBDqSmOaWu0ld+iEmOqu1vPKixYyRf hmeD3VvMeoadMfmEN71y+jwbE7MfUbJC1bZPtE1613zpbPFHUe8oVnnV2EvLXYysAms5 1veFSBnWY1IodAcSkOtCS+HsjQHBK+rGh36SX5VdG6RfZ7kSuCRJTsBrijr7llV5LIAI 9IXA5ya0Cl/CDuxDxAa93ZCFjxFVmYs9SLUG+IAVNs7Vgvk9GfoGrb3xt1Ir9k0b348n +9RQEcDm2HZ/MRKRJL7jm6nwTQldfsLsYIZByLtaqrvIRKZAnPU/4RKKWskEBL2u00bH Wzwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccIIBRUD0FOaJe5AW9sIvP1QuNd2dt4C7OK6LTDW8QY=; b=unoHnqPtHlVWUtVW6sR6ByUg9w3aNToi8hAXf2P59o6aOip3Xhww4afq4tgLtxam1P TCExSobaQFI5iugs4vRZVsAc1EtonBPuceIvSE01zmpx4MAl1q9pDq9viWZ8BrfsMyvZ r+XlMirKDt6leHsKBiAQ6C0KPD2s2Z5LmVA84CQOwa+tyeZM9gM/AiDdQbUZkbZOeH7b aexdCko+AkK7uSipc9GMFnfnXtb0B8pReXSZTPX5445qnFKKB5A7/DWoivrIDTHcV4aR k5XvreKn5pWRVePuDw2nkWykwONhHwnafwu0w4hF0tLtJEFiXDkCZke+OFyx2xrirTLX qA+A== X-Gm-Message-State: AOAM530MT7N9L9bukOOM1K8Ubb+/6WdI82fF7ZPnDFgUrLW6h9EasQaW AY8vLbYeGKS3fm5RUHcgBsblSCpOhGY+rQ== X-Google-Smtp-Source: ABdhPJwUCkNxzZVujwfZwAEUtajanyEzxe7uaXkN3yRr4Ug+16r1X1a+ruoc7ZazC4wAAljtbxG/pQ== X-Received: by 2002:aca:d416:: with SMTP id l22mr7557877oig.124.1619870365313; Sat, 01 May 2021 04:59:25 -0700 (PDT) Received: from localhost ([2806:2f0:4060:638f:a2c5:89ff:fe0c:1151]) by smtp.gmail.com with ESMTPSA id c7sm1389008oot.42.2021.05.01.04.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 04:59:25 -0700 (PDT) From: Felipe Contreras To: notmuch@notmuchmail.org Subject: [PATCH 0/9] test: ruby: several cleanups and simplifications Date: Sat, 1 May 2021 06:59:14 -0500 Message-Id: <20210501115923.483816-1-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Message-ID-Hash: BVFQ56O7OPVU7VVHF32PUM5IDMU4E2C2 X-Message-ID-Hash: BVFQ56O7OPVU7VVHF32PUM5IDMU4E2C2 X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor , Ludovic LANGE , Tomi Ollila , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619870391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=N1nsTOwKoZjYXsCMlMkw5G9MtSnA0YH7LI06PP2BC1k=; b=okkobX71o+4u3Ts7xcIhdrh/UhgwdJqA6RlxD4skMUpYs5IQUdcQK2lutI2IhfhToBXO1U 5JnwpYx3JPxq4EokSLdCYF6q7Q5HoZA1toSXNYxuBCB+k8aLlg/uQIvr735Xj/p3EIAEaj YsCfqtoRSkMWqr1iC7ihN6lQpLx2ou11EIA3odV9B9NCIll4WwTl2qiMM7LQw0I6e+Etdf oXmDtrEiOjOVWorPrn8Igb9xFzy2oFizx+hs0BKnG5N9mZpiT0NY6otvLYEsrluqxtAVGu Q7wD0OKkzjvnesS6X2crJDXlTFh4agmcB1k0m01U7faAe7JN/dHkFzib/T3wOA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619870391; a=rsa-sha256; cv=none; b=I0EnIfh2sUDgqobbDZno/MCtoqT1AubEjKQykJV9DiV+I40R9ePPWwT59ckeiir/tdltk5 wNgf0oTuMIw3LQGLhs1A7S6nBECFJg1YmMSM3mconymDn0k251cApjZz14eY+48jCNUQWa 6UgvpHdPNmOJ1t5ALa5A1Wij4IyJbKr/iVjVTqw/HhlngYK7Upn6VrrFFfIR+HX7N7n/lX Wp43ClzzB2+E0YE1IV1crvj1SOV0aSJVFFH0LFeWTZa2dsH5Wul3z3C1qrjT4Uz3bYHwnR eYiZiu/b8Z2jrpMo3EnbqTQhulKn9pNrMu9ZeNYc/DxrPX6YnUnAREo1GhI/+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=GUazO8cO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=GUazO8cO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D7DDE1A5D7 X-Spam-Score: -1.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: uuK9obB/yF8m I found a lot of areas of improvement in the Ruby tests, so I decided to clean them up. With these changes the tests are now much simpler and follow more closely the typical Ruby idioms. Felipe Contreras (9): test: move test_ruby() inside the only client test: ruby: refactor test_ruby() test: ruby: simplify MAIL_DIR check test: ruby: simplify MAIL_DIR initialization test: ruby: simplify test_ruby() test: ruby: use much more standard puts test: ruby: use much more standard Ruby idioms test: ruby: don't use instance variables test: ruby: simplify output comparison test/T395-ruby.sh | 94 +++++++++++++++-------------------------------- test/test-lib.sh | 4 -- 2 files changed, 30 insertions(+), 68 deletions(-) -- 2.31.0