From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uKcnCocRbWCFHwEAgWs5BA (envelope-from ) for ; Wed, 07 Apr 2021 03:57:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SGkTBIcRbWDlEgAA1q6Kng (envelope-from ) for ; Wed, 07 Apr 2021 01:57:27 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2BEEAE7C for ; Wed, 7 Apr 2021 03:57:26 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B26221FAC2; Tue, 6 Apr 2021 21:56:26 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id D9B3A29050 for ; Tue, 6 Apr 2021 21:55:53 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id CF32E5FA96; Tue, 6 Apr 2021 21:55:53 -0400 (EDT) Received: (nullmailer pid 2964258 invoked by uid 1000); Wed, 07 Apr 2021 01:55:35 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 26/28] CLI/config: remove calls to notmuch_config_open from top level Date: Tue, 6 Apr 2021 22:55:28 -0300 Message-Id: <20210407015530.2964017-27-david@tethera.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210407015530.2964017-1-david@tethera.net> References: <20210407015530.2964017-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: P5CSMSUDSMKPSMAP2RU7UJ7K6ROALJB7 X-Message-ID-Hash: P5CSMSUDSMKPSMAP2RU7UJ7K6ROALJB7 X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617760646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sQH/yolXiHCSkS0tvL2TghJBzh+F7XbfjFrReSUaD20=; b=KcVEG1d/Qk9VYEDc2suSsdPW+y3Ab+QArDNw2p6h8o1NA6vUbhjqmxdGoudWcT8E4Ch/JP iYvz+PRZB6VpRsBCOuo1NqqUKuNdLDHSQi24zW6uoNPwNBDgSykNEi0Q9BmOJDrEFITP01 ELnw1u0/hk3+vIXSUTtHRMpC4TVec6lmc/x+qm4NjZx7MmAKUiZ+y6RsZwzMARpQ05w2JP yHsmcM15cUrQuaFowjBWLbKmlUwek1BB0TtjNCQ9JTCy+BE0hG3Pxnup+/WQG/YiB5bQ6x H4vwfwSDHqdhrJgN6g5kJHvq2znohBUwFL8CsNdeVdzJ6GiNMO4YS2rGraFiqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617760646; a=rsa-sha256; cv=none; b=QTKv+rN4q+yKyeEQbo/AntaNIlUlVdStQrAYgOFoxyjDtdrQdT991PtFrdFbTBSxX9GvZN COV4CLNlkbI7dh8zz/sm3VCBtv+MZCxG4hYlBrmU4NyADGgwdy4ohX1mUN7Z9y5+NL+SZh bVbwTM4Viq27KG5zABkwOGW1HVuEBodHHtCCkGHgaE0SrxwdgPE15/LGhqJ1rt3nX8AwuC PbzmNo8fLBln5R0qhFF43Wmu4jnvjND0LtZ3oIyGS4h5TcegNsQnEQjMlqBF6YHWBi5GG9 0+mrS+rl6YU0DaurYz3mImPgOyDnb87WyT0p3dZqLzzOEN226VCnVJFfs5AbIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.99 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A2BEEAE7C X-Spam-Score: -0.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: xpkRzJZcf8oj This will allow simplifying the subcommand interface. Change the internal API to notmuch_config_open to not tie it to the implementation of subcommands in notmuch.c. It also fixes a previously broken test, since notmuch_config_open does not understand the notion of the empty string as a config file name. --- notmuch-client.h | 3 +-- notmuch-config.c | 28 +++++++++++++++++----------- notmuch-setup.c | 11 ++++++++++- notmuch.c | 40 ++++++++++++++++++---------------------- test/T055-path-config.sh | 1 - 5 files changed, 46 insertions(+), 37 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index a1d8dfe9..a5b3c518 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -267,7 +267,6 @@ json_quote_str (const void *ctx, const char *str); /* notmuch-config.c */ typedef enum { - NOTMUCH_COMMAND_CONFIG_OPEN = 1 << 0, NOTMUCH_COMMAND_CONFIG_CREATE = 1 << 1, NOTMUCH_COMMAND_DATABASE_EARLY = 1 << 2, NOTMUCH_COMMAND_DATABASE_WRITE = 1 << 3, @@ -278,7 +277,7 @@ typedef enum { notmuch_config_t * notmuch_config_open (notmuch_database_t *notmuch, const char *filename, - notmuch_command_mode_t config_mode); + bool create); void notmuch_config_close (notmuch_config_t *config); diff --git a/notmuch-config.c b/notmuch-config.c index c4283576..7aac8e94 100644 --- a/notmuch-config.c +++ b/notmuch-config.c @@ -248,7 +248,7 @@ get_config_from_file (notmuch_config_t *config, bool create_new) notmuch_config_t * notmuch_config_open (notmuch_database_t *notmuch, const char *filename, - notmuch_command_mode_t config_mode) + bool create) { char *notmuch_config_env = NULL; @@ -272,13 +272,9 @@ notmuch_config_open (notmuch_database_t *notmuch, config->key_file = g_key_file_new (); - if (config_mode & NOTMUCH_COMMAND_CONFIG_OPEN) { - bool create_new = (config_mode & NOTMUCH_COMMAND_CONFIG_CREATE) != 0; - - if (! get_config_from_file (config, create_new)) { - talloc_free (config); - return NULL; - } + if (! get_config_from_file (config, create)) { + talloc_free (config); + return NULL; } if (config->is_new) @@ -582,13 +578,14 @@ _set_db_config (notmuch_database_t *notmuch, const char *key, int argc, char **a } static int -notmuch_config_command_set (notmuch_config_t *config, notmuch_database_t *notmuch, +notmuch_config_command_set (unused(notmuch_config_t *config), notmuch_database_t *notmuch, int argc, char *argv[]) { char *group, *key; config_key_info_t *key_info; + notmuch_config_t *config; bool update_database = false; - int opt_index; + int opt_index, ret; char *item; notmuch_opt_desc_t options[] = { @@ -629,6 +626,11 @@ notmuch_config_command_set (notmuch_config_t *config, notmuch_database_t *notmuc if (_item_split (item, &group, &key)) return 1; + config = notmuch_config_open (notmuch, + notmuch_config_path (notmuch), false); + if (! config) + return 1; + /* With only the name of an item, we clear it from the * configuration file. * @@ -649,7 +651,11 @@ notmuch_config_command_set (notmuch_config_t *config, notmuch_database_t *notmuc break; } - return notmuch_config_save (config); + ret = notmuch_config_save (config); + + notmuch_config_close (config); + + return ret; } static diff --git a/notmuch-setup.c b/notmuch-setup.c index e9b81be8..221ce934 100644 --- a/notmuch-setup.c +++ b/notmuch-setup.c @@ -124,7 +124,7 @@ parse_tag_list (void *ctx, char *response) } int -notmuch_setup_command (notmuch_config_t *config, +notmuch_setup_command (unused(notmuch_config_t *config), notmuch_database_t *notmuch, int argc, char *argv[]) { @@ -132,6 +132,7 @@ notmuch_setup_command (notmuch_config_t *config, size_t response_size = 0; GPtrArray *other_emails; notmuch_config_values_t *new_tags, *search_exclude_tags, *emails; + notmuch_config_t *config; #define prompt(format, ...) \ do { \ @@ -151,6 +152,11 @@ notmuch_setup_command (notmuch_config_t *config, fprintf (stderr, "Warning: ignoring --uuid=%s\n", notmuch_requested_db_uuid); + config = notmuch_config_open (notmuch, + notmuch_config_path (notmuch), true); + if (! config) + return EXIT_FAILURE; + if (notmuch_config_is_new (config)) welcome_message_pre_setup (); @@ -232,6 +238,9 @@ notmuch_setup_command (notmuch_config_t *config, if (notmuch_config_save (config)) return EXIT_FAILURE; + if (config) + notmuch_config_close (config); + if (notmuch_config_is_new (config)) welcome_message_post_setup (); diff --git a/notmuch.c b/notmuch.c index 61663908..757d0eae 100644 --- a/notmuch.c +++ b/notmuch.c @@ -141,11 +141,9 @@ notmuch_process_shared_indexing_options (notmuch_database_t *notmuch) static command_t commands[] = { - { NULL, notmuch_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE - | NOTMUCH_COMMAND_CONFIG_LOAD, + { NULL, notmuch_command, NOTMUCH_COMMAND_CONFIG_CREATE | NOTMUCH_COMMAND_CONFIG_LOAD, "Notmuch main command." }, - { "setup", notmuch_setup_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE - | NOTMUCH_COMMAND_CONFIG_LOAD, + { "setup", notmuch_setup_command, NOTMUCH_COMMAND_CONFIG_CREATE | NOTMUCH_COMMAND_CONFIG_LOAD, "Interactively set up notmuch for first use." }, { "new", notmuch_new_command, NOTMUCH_COMMAND_DATABASE_EARLY | NOTMUCH_COMMAND_DATABASE_WRITE | @@ -177,7 +175,7 @@ static command_t commands[] = { { "reindex", notmuch_reindex_command, NOTMUCH_COMMAND_DATABASE_EARLY | NOTMUCH_COMMAND_DATABASE_WRITE, "Re-index all messages matching the search terms." }, - { "config", notmuch_config_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_LOAD, + { "config", notmuch_config_command, NOTMUCH_COMMAND_CONFIG_LOAD, "Get or set settings in the notmuch configuration file." }, #if WITH_EMACS { "emacs-mua", NULL, 0, @@ -376,15 +374,26 @@ notmuch_help_command (unused (notmuch_config_t *config), unused(notmuch_database * to be more clever about this in the future. */ static int -notmuch_command (notmuch_config_t *config, +notmuch_command (unused(notmuch_config_t *config), notmuch_database_t *notmuch, unused(int argc), unused(char **argv)) { - /* If the user has never configured notmuch, then run + + const char *config_path; + + /* If the user has not created a configuration file, then run * notmuch_setup_command which will give a nice welcome message, * and interactively guide the user through the configuration. */ - if (notmuch_config_is_new (config)) - return notmuch_setup_command (config, notmuch, 0, NULL); + config_path = notmuch_config_path (notmuch); + if (access (config_path, R_OK | F_OK) == -1) { + if (errno != ENOENT) { + fprintf (stderr, "Error: %s config file access failed: %s\n", config_path, + strerror (errno)); + return EXIT_FAILURE; + } else { + return notmuch_setup_command (NULL, notmuch, 0, NULL); + } + } printf ("Notmuch is configured and appears to have a database. Excellent!\n\n" "At this point you can start exploring the functionality of notmuch by\n" @@ -580,22 +589,9 @@ main (int argc, char *argv[]) } - if (command->mode & NOTMUCH_COMMAND_CONFIG_OPEN) { - if (! config_file_name) - config_file_name = notmuch_config_path (notmuch); - - config = notmuch_config_open (notmuch, config_file_name, command->mode); - if (! config) { - ret = EXIT_FAILURE; - goto DONE; - } - } ret = (command->function)(config, notmuch, argc - opt_index, argv + opt_index); DONE: - if (config) - notmuch_config_close (config); - talloc_report = getenv ("NOTMUCH_TALLOC_REPORT"); if (talloc_report && strcmp (talloc_report, "") != 0) { /* this relies on the previous call to diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh index 535c41e9..2045a555 100755 --- a/test/T055-path-config.sh +++ b/test/T055-path-config.sh @@ -258,7 +258,6 @@ EOF case $config in XDG*) test_begin_subtest "Set shadowed config value in database ($config)" - test_subtest_known_broken name=${RANDOM} value=${RANDOM} key=test${test_count}.${name} -- 2.30.2