From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4D5COsEXTmAfEwAA0tVLHw (envelope-from ) for ; Sun, 14 Mar 2021 14:03:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GCIDNsEXTmCgQgAAB5/wlQ (envelope-from ) for ; Sun, 14 Mar 2021 14:03:45 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 759C01CF86 for ; Sun, 14 Mar 2021 15:03:45 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 450FD27D53; Sun, 14 Mar 2021 10:02:50 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 19E6527C28 for ; Sun, 14 Mar 2021 10:02:32 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 1176C5FA96; Sun, 14 Mar 2021 10:02:32 -0400 (EDT) Received: (nullmailer pid 183640 invoked by uid 1000); Sun, 14 Mar 2021 14:02:19 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 05/22] CLI/show: complete conversion to new configuration framework. Date: Sun, 14 Mar 2021 11:02:00 -0300 Message-Id: <20210314140217.183425-6-david@tethera.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210314140217.183425-1-david@tethera.net> References: <20210314140217.183425-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ZTXFPF2AGHGU3ZOXCWDK55VHIID5JHOY X-Message-ID-Hash: ZTXFPF2AGHGU3ZOXCWDK55VHIID5JHOY X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615730625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qjvFtm8u7E+ww8Q0Cc/vPeiN+I7PVjfpGkyM8NE6YmA=; b=OaMKp4qtFuvwZHZ5A1quGYaosti48J4uU79ZU6iGefoKnDl8O2Y4QaHEWWSw9i0bjp9rZ0 MC473sMsoxcxvxwkkd0e44iYBweiR/nB/gJHJ7f8rEgSlaFF81ldgl5bDZ4+F57MbbxNxj X9xTLEeV8mQGxDtzYW2n0pZJ6gy7/LHf6mWPCJOhxDOl2whlsVKFdE44+J88Icw/wQGw2t rxpoVU+0GLfwsLtI1nCziSRBQBhMY8YI0ibMgUwgvO430/jA96/u7JV9Opddgbt2LHj5q6 BnmFeCc7Oqpn4RYwkjvEYlO4bLXvgCS/vYzqH3C+pWFuoVpwNUEiOtJQtqDHYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615730625; a=rsa-sha256; cv=none; b=GkfnFNhiYAG00tR2tyM57Q2viEIV2TESIQHe2WBX/HzLlYeyGW5tSBP6bPgKaeLy6Wj7NH 4BAKDlrFq/OPWX2XHRI2t/WIlcP5nYmN8RUot8Ey01+uaOjlYT4r9KvlHeIY67/3Plcmv5 kyJmxGdu/BdCjdWjWOZijnpRIQEdi88XnVXliHUNGVEd7OyWLCrXcDzG8gQIVnuwq6b+/A zm8D/9aNU56PPz7JLwWyZsaPGzpHVw2n//07ucpgnxXkI4pBvu3XH1h1quazoKZE1z+97h D6OjvaVI33chORMumn5GkmYP7rmtAXEU+xJHtuU3vJkn3nbD7GR44UYafnCC/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.00 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 759C01CF86 X-Spam-Score: -1.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: GTjO/FMzSIIf In order to open the database in main() for this command, we may need to re-open it in the (possibly less common) case where crypto options require write access. --- notmuch-show.c | 28 ++++++++-------------------- notmuch.c | 2 +- test/T035-read-config.sh | 2 -- 3 files changed, 9 insertions(+), 23 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b6b53991..5fd1ce25 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -1225,10 +1225,9 @@ static const notmuch_show_format_t *formatters[] = { }; int -notmuch_show_command (notmuch_config_t *config, unused(notmuch_database_t *notmuch), +notmuch_show_command (unused (notmuch_config_t *config), notmuch_database_t *notmuch, int argc, char *argv[]) { - notmuch_database_t *notmuch; notmuch_query_t *query; char *query_string; int opt_index, ret; @@ -1245,7 +1244,7 @@ notmuch_show_command (notmuch_config_t *config, unused(notmuch_database_t *notmu bool entire_thread_set = false; bool single_message; bool unthreaded = FALSE; - char *status_string = NULL; + notmuch_status_t status; notmuch_opt_desc_t options[] = { { .opt_keyword = &format, .name = "format", .keywords = @@ -1336,26 +1335,15 @@ notmuch_show_command (notmuch_config_t *config, unused(notmuch_database_t *notmu "Warning: --include-html only implemented for format=text, format=json and format=sexp\n"); } - notmuch_database_mode_t mode = NOTMUCH_DATABASE_MODE_READ_ONLY; - - if (params.crypto.decrypt == NOTMUCH_DECRYPT_TRUE) - mode = NOTMUCH_DATABASE_MODE_READ_WRITE; - if (notmuch_database_open_with_config (NULL, - mode, - _notmuch_config_get_path (config), - NULL, - ¬much, - &status_string)) { - if (status_string) { - fputs (status_string, stderr); - free (status_string); + if (params.crypto.decrypt == NOTMUCH_DECRYPT_TRUE) { + status = notmuch_database_reopen (notmuch, NOTMUCH_DATABASE_MODE_READ_WRITE); + if (status) { + fprintf (stderr, "Error reopening database for READ_WRITE: %s\n", + notmuch_status_to_string (status)); + return EXIT_FAILURE; } - - return EXIT_FAILURE; } - config = NULL; - notmuch_exit_if_unmatched_db_uuid (notmuch); query_string = query_string_from_args (notmuch, argc - opt_index, argv + opt_index); diff --git a/notmuch.c b/notmuch.c index 5e56209b..f2bf9c24 100644 --- a/notmuch.c +++ b/notmuch.c @@ -156,7 +156,7 @@ static command_t commands[] = { "Search for messages matching the given search terms." }, { "address", notmuch_address_command, NOTMUCH_COMMAND_DATABASE_EARLY, "Get addresses from messages matching the given search terms." }, - { "show", notmuch_show_command, NOTMUCH_COMMAND_CONFIG_OPEN, + { "show", notmuch_show_command, NOTMUCH_COMMAND_DATABASE_EARLY, "Show all messages matching the search terms." }, { "count", notmuch_count_command, NOTMUCH_COMMAND_DATABASE_EARLY, "Count messages matching the search terms." }, diff --git a/test/T035-read-config.sh b/test/T035-read-config.sh index 205d1736..ac0f420b 100755 --- a/test/T035-read-config.sh +++ b/test/T035-read-config.sh @@ -378,7 +378,6 @@ restore_database test_expect_equal "$output" "OK" test_begin_subtest "show with alternate config (xdg)" -test_subtest_known_broken backup_database notmuch tag -- +foobar17 '*' xdg_config @@ -389,7 +388,6 @@ restore_config test_expect_equal "$output" "OK" test_begin_subtest "show with alternate config (xdg+profile)" -test_subtest_known_broken backup_database notmuch tag -- +foobar17 '*' xdg_config foobar17 -- 2.30.1