From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GIFGAnvhQGDkMwAA0tVLHw (envelope-from ) for ; Thu, 04 Mar 2021 13:32:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UCe4OXrhQGCPMQAA1q6Kng (envelope-from ) for ; Thu, 04 Mar 2021 13:32:42 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A990D164FC for ; Thu, 4 Mar 2021 14:32:42 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 556D927D25; Thu, 4 Mar 2021 08:32:02 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 5C3AE2757B for ; Thu, 4 Mar 2021 08:31:42 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 444325FA96; Thu, 4 Mar 2021 08:31:42 -0500 (EST) Received: (nullmailer pid 4053546 invoked by uid 1000); Thu, 04 Mar 2021 13:31:28 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 03/22] lib: save path of xapian database in notmuch struct. Date: Thu, 4 Mar 2021 09:31:06 -0400 Message-Id: <20210304133125.4050229-4-david@tethera.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210304133125.4050229-1-david@tethera.net> References: <20210304133125.4050229-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FGCQL4P5D2YJSBYIHIHUELVSOT3V4VTM X-Message-ID-Hash: FGCQL4P5D2YJSBYIHIHUELVSOT3V4VTM X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614864762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Mf5xg/lnRVIwMRcmU9WfcSWhd8iDIu2O9tuMTKiFFcg=; b=d6ZZKOYUaG95YXPwWCeNFKH1Lqs0NNdCIhS5cWziRROelzGeaSgNprYL1vxBYSrqDSWznM 9l4I/vfxhpSLP5fePqVDpQLLqdJNO2cJOz3GoUs4EhtzzdXy8rCkZmqi30ozrBTAibHBPy kZ28ABqznRuBj6lFX71yNDcLoQGuXJbhQoUHHaxG7Sw3h5ALD7eWUSlS67vwLS8ZeyOSG4 AEeAA4R6b0BcI5tnLzXGuQzizEAEMvD4fhXZcmNGxsFo/vbOcJFZ+vqJ294hpWCWsiJ9Fo o6Ts6meiRHZl8AUyjZW2ib4xwT2wcQEXx5eecGgqqya/MRM7aJmSYU551nRaWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614864762; a=rsa-sha256; cv=none; b=JJRCOHEYaDCxJfsosMbivc/dv413ktflAz7KEVY/Ouvhn8QeIhWF+xmxVWJiogzdzBkMcg TL1QLv674SKobwmkTDbTjQAQHK1YHdYvIoceKwLii7Nl2+5vLFU0u4n6r/SRzqR5nZ4bSF 4bCQaiLrysmB2EqkBa2lsuuttgl06GwYoSXpLhURMgDm4AkgKBu7R7/hdWPQqT6S0rANBo 4MY0XHKTByrTOfZtzTLSar+2Nj6eSpGD4rqtP/HI1OzPd+8VJu6MHKmNgBBQw3KykjA56g roseX+xdXgm/t1+yhkgaGelwFPsyeHKlLg8/vpQwMGDmf555EhO1SPoxewhtMQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.88 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A990D164FC X-Spam-Score: -0.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: XO5awzj16a2W This will allow re-opening in a different mode (read/write vs. read-only) with current Xapian API. --- lib/database-private.h | 4 ++++ lib/open.cc | 19 ++++++++++--------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index d83cf0d0..d936b216 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -189,8 +189,12 @@ operator& (notmuch_field_flag_t a, notmuch_field_flag_t b) struct _notmuch_database { bool exception_reported; + /* Path to database parent directory and or/mail root */ char *path; + /* Path to actual database */ + const char *xapian_path; + int atomic_nesting; /* true if changes have been made in this atomic section */ bool atomic_dirty; diff --git a/lib/open.cc b/lib/open.cc index 3b86065b..8885ec90 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -193,7 +193,7 @@ notmuch_database_open_with_config (const char *database_path, notmuch_status_t status = NOTMUCH_STATUS_SUCCESS; void *local = talloc_new (NULL); notmuch_database_t *notmuch = NULL; - char *notmuch_path, *xapian_path, *incompat_features; + char *notmuch_path, *incompat_features; char *message = NULL; struct stat st; int err; @@ -218,12 +218,6 @@ notmuch_database_open_with_config (const char *database_path, goto DONE; } - if (! (xapian_path = talloc_asprintf (local, "%s/%s", notmuch_path, "xapian"))) { - message = strdup ("Out of memory\n"); - status = NOTMUCH_STATUS_OUT_OF_MEMORY; - goto DONE; - } - /* Initialize the GLib type system and threads */ #if ! GLIB_CHECK_VERSION (2, 35, 1) g_type_init (); @@ -245,16 +239,23 @@ notmuch_database_open_with_config (const char *database_path, notmuch->writable_xapian_db = NULL; notmuch->atomic_nesting = 0; notmuch->view = 1; + + if (! (notmuch->xapian_path = talloc_asprintf (notmuch, "%s/%s", notmuch_path, "xapian"))) { + message = strdup ("Out of memory\n"); + status = NOTMUCH_STATUS_OUT_OF_MEMORY; + goto DONE; + } + try { std::string last_thread_id; std::string last_mod; if (mode == NOTMUCH_DATABASE_MODE_READ_WRITE) { - notmuch->writable_xapian_db = new Xapian::WritableDatabase (xapian_path, + notmuch->writable_xapian_db = new Xapian::WritableDatabase (notmuch->xapian_path, DB_ACTION); notmuch->xapian_db = notmuch->writable_xapian_db; } else { - notmuch->xapian_db = new Xapian::Database (xapian_path); + notmuch->xapian_db = new Xapian::Database (notmuch->xapian_path); } /* Check version. As of database version 3, we represent -- 2.30.1