From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8HxOJs7aQGD4YwAA0tVLHw (envelope-from ) for ; Thu, 04 Mar 2021 13:04:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UPMmIs7aQGCkIAAA1q6Kng (envelope-from ) for ; Thu, 04 Mar 2021 13:04:14 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C1B06221EA for ; Thu, 4 Mar 2021 14:04:13 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0D6A327C5E; Thu, 4 Mar 2021 08:02:32 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id A4F5427569 for ; Thu, 4 Mar 2021 08:02:05 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 8F3275FA96; Thu, 4 Mar 2021 08:02:05 -0500 (EST) Received: (nullmailer pid 4047202 invoked by uid 1000); Thu, 04 Mar 2021 13:01:45 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 19/27] CLI/config: drop cached data from notmuch_config_t Date: Thu, 4 Mar 2021 09:01:31 -0400 Message-Id: <20210304130139.4046183-20-david@tethera.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210304130139.4046183-1-david@tethera.net> References: <20210304130139.4046183-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 47G6PT3MOY5USYQHNGD24CLAADQ4IZJP X-Message-ID-Hash: 47G6PT3MOY5USYQHNGD24CLAADQ4IZJP X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614863054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z6tJb7CeaiA9XfCc15Wzp8z+qcGXoKg1oQYF9m+k/Xk=; b=So4NpNd5snoDDnFWOoeh/5rpItqfkBMQoUFoXkdRQ75E5ao4Almfezeno66iWxRbXr4O91 G4pHixlGUNRO+sta5iNP6GUCbZnxJ86NMO78/hsMfXapEAek1692+h+Xxdhx5xMsWJjs1X mtxAFg6Qzs6BWMCoqTr4wfgTRNOyzPj2ayro48PFZrvrrXD0CDMlwT40tW9pYOPIglodDE b6LKm7woej/bXFWdnDPe5lxpYxitDfzjiHCFKNj5U/R1tcxXE9e24jU8JPZrNCSfNxBNud 9qHoVCimJ0j1EAtlb66M59ihBKcIKGlrnnNKm61notDpnZ0M3yJLoqAaOQjcEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614863054; a=rsa-sha256; cv=none; b=pZtaP5xI7pDUbC/wa7+qfjF1u/P76UxIZYunBpTSGXBZMxwu4pzHG4czErqo8y9KJpvj88 z+0s6gkntSpqeukLO3FdXg1q7AZC7ZZ9Coo6MEyuiPZi7uVLPJ3a+SOq0mGvflrPtTY/8w x7zuXNWS6sskbmACZJibqlEWmjxSSjHLKZYY3ZXIfIXLKupUcetWl5rRyblXycX59+QNRW NDEgpyXJlTyyDfTW1VeyCPI53AORMB6hzH6jOSNRKPZOZF4mvnHjWpQoPyPlgt6mc/6GQ3 bavjv+r89n82mWipxfiVrFkIj3AHShEoFsAKyHuuav2tSlKTLCnm19xBe7MtbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C1B06221EA X-Spam-Score: -0.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: dYM+Pjk7CX+2 The idea is to preserve notmuch_config_t as a thin wrapper for GKeyFile. --- notmuch-config.c | 48 +++++++++--------------------------------------- 1 file changed, 9 insertions(+), 39 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index 774c8936..93a1018e 100644 --- a/notmuch-config.c +++ b/notmuch-config.c @@ -118,19 +118,6 @@ struct _notmuch_config { char *filename; GKeyFile *key_file; bool is_new; - - char *database_path; - char *user_name; - char *user_primary_email; - const char **user_other_email; - size_t user_other_email_length; - const char **new_tags; - size_t new_tags_length; - const char **new_ignore; - size_t new_ignore_length; - bool maildir_synchronize_flags; - const char **search_exclude_tags; - size_t search_exclude_tags_length; }; static int @@ -142,7 +129,6 @@ notmuch_config_destructor (notmuch_config_t *config) return 0; } - static bool get_config_from_file (notmuch_config_t *config, bool create_new) { @@ -275,9 +261,6 @@ notmuch_config_open (notmuch_database_t *notmuch, talloc_set_destructor (config, notmuch_config_destructor); - /* non-zero defaults */ - config->maildir_synchronize_flags = true; - if (filename) { config->filename = talloc_strdup (config, filename); } else if ((notmuch_config_env = getenv ("NOTMUCH_CONFIG"))) { @@ -391,48 +374,40 @@ notmuch_config_is_new (notmuch_config_t *config) } static void -_config_set (notmuch_config_t *config, char **field, +_config_set (notmuch_config_t *config, const char *group, const char *key, const char *value) { g_key_file_set_string (config->key_file, group, key, value); - - /* drop the cached value */ - talloc_free (*field); - *field = NULL; } static void _config_set_list (notmuch_config_t *config, const char *group, const char *key, const char *list[], - size_t length, const char ***config_var ) + size_t length) { g_key_file_set_string_list (config->key_file, group, key, list, length); - - /* drop the cached value */ - talloc_free (*config_var); - *config_var = NULL; } void notmuch_config_set_database_path (notmuch_config_t *config, const char *database_path) { - _config_set (config, &config->database_path, "database", "path", database_path); + _config_set (config, "database", "path", database_path); } void notmuch_config_set_user_name (notmuch_config_t *config, const char *user_name) { - _config_set (config, &config->user_name, "user", "name", user_name); + _config_set (config, "user", "name", user_name); } void notmuch_config_set_user_primary_email (notmuch_config_t *config, const char *primary_email) { - _config_set (config, &config->user_primary_email, "user", "primary_email", primary_email); + _config_set (config, "user", "primary_email", primary_email); } void @@ -440,8 +415,7 @@ notmuch_config_set_user_other_email (notmuch_config_t *config, const char *list[], size_t length) { - _config_set_list (config, "user", "other_email", list, length, - &(config->user_other_email)); + _config_set_list (config, "user", "other_email", list, length); } void @@ -449,8 +423,7 @@ notmuch_config_set_new_tags (notmuch_config_t *config, const char *list[], size_t length) { - _config_set_list (config, "new", "tags", list, length, - &(config->new_tags)); + _config_set_list (config, "new", "tags", list, length); } void @@ -458,8 +431,7 @@ notmuch_config_set_new_ignore (notmuch_config_t *config, const char *list[], size_t length) { - _config_set_list (config, "new", "ignore", list, length, - &(config->new_ignore)); + _config_set_list (config, "new", "ignore", list, length); } void @@ -467,8 +439,7 @@ notmuch_config_set_search_exclude_tags (notmuch_config_t *config, const char *list[], size_t length) { - _config_set_list (config, "search", "exclude_tags", list, length, - &(config->search_exclude_tags)); + _config_set_list (config, "search", "exclude_tags", list, length); } @@ -742,5 +713,4 @@ notmuch_config_set_maildir_synchronize_flags (notmuch_config_t *config, { g_key_file_set_boolean (config->key_file, "maildir", "synchronize_flags", synchronize_flags); - config->maildir_synchronize_flags = synchronize_flags; } -- 2.30.1