From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +ASaGOnaQGALUwAA0tVLHw (envelope-from ) for ; Thu, 04 Mar 2021 13:04:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kNFwFOnaQGAWHgAA1q6Kng (envelope-from ) for ; Thu, 04 Mar 2021 13:04:41 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DCF9D1607A for ; Thu, 4 Mar 2021 14:04:40 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EC0AB27D2D; Thu, 4 Mar 2021 08:02:40 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 529F427576 for ; Thu, 4 Mar 2021 08:02:10 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 4AE485FA96; Thu, 4 Mar 2021 08:02:10 -0500 (EST) Received: (nullmailer pid 4047190 invoked by uid 1000); Thu, 04 Mar 2021 13:01:45 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 13/27] CLI/setup: switch to new configuration framework Date: Thu, 4 Mar 2021 09:01:25 -0400 Message-Id: <20210304130139.4046183-14-david@tethera.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210304130139.4046183-1-david@tethera.net> References: <20210304130139.4046183-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: VZGJKJBINMHT3R4ZHR4SZ3IFRJZLXX5U X-Message-ID-Hash: VZGJKJBINMHT3R4ZHR4SZ3IFRJZLXX5U X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614863081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NuIz4zCSJWc3fS7xsh04UAZ0aVaq0HKnxBPxW7Nb370=; b=qmuo4ssH+/iSU+OLVRtoDuT6jXOwvaao3tpTGvZ7Sb7boFGVbSptEXKgsGz3hu0xb7dSSb gk5iAUYHCx5OrHdrzu7J5CsQq3tyVOyPvWR2HX/Fcxd9HugbP5hrjmjOOFmn+qfGlwIQuZ NXfDjy3hMM9TQkWI+Aru4+4y4WHUrjLbd6enPcshN69BOa9TMdw4U5ldJBixr7uN467+BV Tmm/cCix6HKBfPnwJEqXBrwgLCoLV8cZHgSdd37dzsj8X9KxoqQT9Xvnem088+pX8Cf9A5 +jICVkJvtyvPpWcRz/bElHthb/uknnQ2TWDjGCld4HBwVwWdnVBmJQR2+OEKDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614863081; a=rsa-sha256; cv=none; b=GgIKPj5xtRR3M8eZHNVKOE1GwyTmsyvrS2lLI/hykSVhL/oCrEnSr4Hizp0NdiFdbVNLc5 NKSgSbcFWtb47XQYFW9jI7w7KDlZ9/O0ZKRcuvvfElj0Bf3pH3TjRBub+SIuyaROs8FUO7 lt2VyDqarJSQaV0SRu+Q+UPQmMlEVBSPyAjw36S6zQMo9eA3+AGkirBghxdhT/c9nfCgzS zc+Zu3a4NPU1kMm0o8mYmc4SjbUZa26hPXskcqWlzbsloC7WOnj62gQi07czX+wiTJhQX0 QXxUzZuJa1/RLOHdUrqCFyL4SpXM/3JwboATqPnEKkhPWGKhVwj5evV/prDqFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: DCF9D1607A X-Spam-Score: -1.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0mA/5IJ1oeQL Most of the changes are the elimination of notmuch_config_t accessor use. We also migrate some of the diagnostics to the top level where we are opening the files in question. --- notmuch-setup.c | 55 +++++++++++++++++++++++-------------------------- notmuch.c | 21 ++++++++++++------- 2 files changed, 39 insertions(+), 37 deletions(-) diff --git a/notmuch-setup.c b/notmuch-setup.c index 67214470..1e22412b 100644 --- a/notmuch-setup.c +++ b/notmuch-setup.c @@ -88,14 +88,17 @@ welcome_message_post_setup (void) } static void -print_tag_list (const char **tags, size_t tags_len) +print_tag_list (notmuch_config_values_t *tags) { - unsigned int i; - - for (i = 0; i < tags_len; i++) { - if (i != 0) - printf (" "); - printf ("%s", tags[i]); + bool first = false; + + for (; + notmuch_config_values_valid(tags); + notmuch_config_values_move_to_next (tags)) { + if (!first) + printf(" "); + first = false; + printf("%s", notmuch_config_values_get (tags)); } } @@ -122,19 +125,13 @@ parse_tag_list (void *ctx, char *response) int notmuch_setup_command (notmuch_config_t *config, - unused(notmuch_database_t *notmuch), + notmuch_database_t *notmuch, int argc, char *argv[]) { char *response = NULL; size_t response_size = 0; - const char **old_other_emails; - size_t old_other_emails_len; GPtrArray *other_emails; - unsigned int i; - const char **new_tags; - size_t new_tags_len; - const char **search_exclude_tags; - size_t search_exclude_tags_len; + notmuch_config_values_t *new_tags, *search_exclude_tags, *emails; #define prompt(format, ...) \ do { \ @@ -157,26 +154,27 @@ notmuch_setup_command (notmuch_config_t *config, if (notmuch_config_is_new (config)) welcome_message_pre_setup (); - prompt ("Your full name [%s]: ", notmuch_config_get_user_name (config)); + prompt ("Your full name [%s]: ", notmuch_config_get (notmuch, NOTMUCH_CONFIG_USER_NAME)); if (strlen (response)) notmuch_config_set_user_name (config, response); prompt ("Your primary email address [%s]: ", - notmuch_config_get_user_primary_email (config)); + notmuch_config_get (notmuch, NOTMUCH_CONFIG_PRIMARY_EMAIL)); if (strlen (response)) notmuch_config_set_user_primary_email (config, response); other_emails = g_ptr_array_new (); - old_other_emails = notmuch_config_get_user_other_email (config, - &old_other_emails_len); - for (i = 0; i < old_other_emails_len; i++) { - prompt ("Additional email address [%s]: ", old_other_emails[i]); + for (emails = notmuch_config_get_values (notmuch, NOTMUCH_CONFIG_OTHER_EMAIL); + notmuch_config_values_valid (emails); + notmuch_config_values_move_to_next (emails)) { + const char *email = notmuch_config_values_get (emails); + + prompt ("Additional email address [%s]: ", email); if (strlen (response)) g_ptr_array_add (other_emails, talloc_strdup (config, response)); else - g_ptr_array_add (other_emails, talloc_strdup (config, - old_other_emails[i])); + g_ptr_array_add (other_emails, talloc_strdup (config, email)); } do { @@ -192,7 +190,7 @@ notmuch_setup_command (notmuch_config_t *config, g_ptr_array_free (other_emails, true); prompt ("Top-level directory of your email archive [%s]: ", - notmuch_config_get_database_path (config)); + notmuch_config_get (notmuch, NOTMUCH_CONFIG_DATABASE_PATH)); if (strlen (response)) { const char *absolute_path; @@ -200,10 +198,10 @@ notmuch_setup_command (notmuch_config_t *config, notmuch_config_set_database_path (config, absolute_path); } - new_tags = notmuch_config_get_new_tags (config, &new_tags_len); + new_tags = notmuch_config_get_values (notmuch, NOTMUCH_CONFIG_NEW_TAGS); printf ("Tags to apply to all new messages (separated by spaces) ["); - print_tag_list (new_tags, new_tags_len); + print_tag_list (new_tags); prompt ("]: "); if (strlen (response)) { @@ -215,11 +213,10 @@ notmuch_setup_command (notmuch_config_t *config, g_ptr_array_free (tags, true); } - - search_exclude_tags = notmuch_config_get_search_exclude_tags (config, &search_exclude_tags_len); + search_exclude_tags = notmuch_config_get_values (notmuch, NOTMUCH_CONFIG_EXCLUDE_TAGS); printf ("Tags to exclude when searching messages (separated by spaces) ["); - print_tag_list (search_exclude_tags, search_exclude_tags_len); + print_tag_list (search_exclude_tags); prompt ("]: "); if (strlen (response)) { diff --git a/notmuch.c b/notmuch.c index d2eb5daa..5e2cbdc8 100644 --- a/notmuch.c +++ b/notmuch.c @@ -139,9 +139,11 @@ notmuch_process_shared_indexing_options (notmuch_database_t *notmuch) static command_t commands[] = { - { NULL, notmuch_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE, + { NULL, notmuch_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE + | NOTMUCH_COMMAND_CONFIG_LOAD, "Notmuch main command." }, - { "setup", notmuch_setup_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE, + { "setup", notmuch_setup_command, NOTMUCH_COMMAND_CONFIG_OPEN | NOTMUCH_COMMAND_CONFIG_CREATE + | NOTMUCH_COMMAND_CONFIG_LOAD, "Interactively set up notmuch for first use." }, { "new", notmuch_new_command, NOTMUCH_COMMAND_DATABASE_EARLY | NOTMUCH_COMMAND_DATABASE_WRITE | NOTMUCH_COMMAND_DATABASE_CREATE, @@ -364,7 +366,7 @@ notmuch_help_command (unused (notmuch_config_t *config), unused(notmuch_database */ static int notmuch_command (notmuch_config_t *config, - unused(notmuch_database_t *notmuch), + notmuch_database_t *notmuch, unused(int argc), unused(char **argv)) { char *db_path; @@ -374,7 +376,7 @@ notmuch_command (notmuch_config_t *config, * notmuch_setup_command which will give a nice welcome message, * and interactively guide the user through the configuration. */ if (notmuch_config_is_new (config)) - return notmuch_setup_command (config, NULL, 0, NULL); + return notmuch_setup_command (config, notmuch, 0, NULL); /* Notmuch is already configured, but is there a database? */ db_path = talloc_asprintf (config, "%s/%s", @@ -558,14 +560,17 @@ main (int argc, char *argv[]) NULL, ¬much, &status_string); - if (status) { + + if (status == NOTMUCH_STATUS_NO_CONFIG && !(command->mode & NOTMUCH_COMMAND_CONFIG_CREATE)) { + fputs ("Try running 'notmuch setup' to create a configuration.", stderr); + goto DONE; + } + + if (status && (status != NOTMUCH_STATUS_NO_CONFIG)) { if (status_string) { fputs (status_string, stderr); free (status_string); } - - if (status == NOTMUCH_STATUS_NO_CONFIG) - fputs ("Try running 'notmuch setup' to create a configuration.", stderr); goto DONE; } -- 2.30.1