From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6BB7OyndKWD3WgAA0tVLHw (envelope-from ) for ; Mon, 15 Feb 2021 02:32:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iMwjNyndKWC3JAAAbx9fmQ (envelope-from ) for ; Mon, 15 Feb 2021 02:32:09 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 454DF1DBD4 for ; Mon, 15 Feb 2021 03:32:09 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 116B520660; Sun, 14 Feb 2021 21:32:02 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4AB381FF5B for ; Sun, 14 Feb 2021 21:32:00 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 39E05606DD; Sun, 14 Feb 2021 21:32:00 -0500 (EST) Received: (nullmailer pid 4069838 invoked by uid 1000); Mon, 15 Feb 2021 02:31:58 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 1/2] lib/open: remove incorrect unused attribute Date: Sun, 14 Feb 2021 22:31:52 -0400 Message-Id: <20210215023153.4069790-1-david@tethera.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Message-ID-Hash: CWQAY3MD5XKKBYVZGQKUXW4BCEMBAC42 X-Message-ID-Hash: CWQAY3MD5XKKBYVZGQKUXW4BCEMBAC42 X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 454DF1DBD4 X-Spam-Score: 0.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: g7drdgRe3/B2 With the current unused macro in lib/notmuch-private.h this seems harmless, but is misleading, since the parameter is in fact used. --- lib/open.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/open.cc b/lib/open.cc index b4637ec5..3b86065b 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -186,7 +186,7 @@ notmuch_status_t notmuch_database_open_with_config (const char *database_path, notmuch_database_mode_t mode, const char *config_path, - unused(const char *profile), + const char *profile, notmuch_database_t **database, char **status_string) { -- 2.30.0