From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sOdED3G8V1/mKwAA0tVLHw (envelope-from ) for ; Tue, 08 Sep 2020 17:16:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4FkfC3G8V1+regAAbx9fmQ (envelope-from ) for ; Tue, 08 Sep 2020 17:16:33 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 79A2F9402CB for ; Tue, 8 Sep 2020 17:16:31 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5915B29B76; Tue, 8 Sep 2020 13:16:22 -0400 (EDT) Received: from jb55.com (unknown [45.79.91.128]) by mail.notmuchmail.org (Postfix) with ESMTPS id 0C4F22931A for ; Tue, 8 Sep 2020 13:16:19 -0400 (EDT) Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id baf0d025 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 8 Sep 2020 17:16:49 +0000 (UTC) From: William Casarin To: notmuch@notmuchmail.org Subject: [PATCH] emacs/tree: declare notmuch-search functions Date: Tue, 8 Sep 2020 10:15:37 -0700 Message-Id: <20200908171536.20679-1-jb55@jb55.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Message-ID-Hash: VQUH5HAAQZDFWWECPMPGCL4TCMFTJMDS X-Message-ID-Hash: VQUH5HAAQZDFWWECPMPGCL4TCMFTJMDS X-MailFrom: jb55@jb55.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "Danilo G . Baio" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 1.53 X-TUID: zFCy6ySuZ7+0 Some are running into undeclarated function errors: > emacs/notmuch-tree.el:1143:1:Warning: the following functions are > not known to be defined: notmuch-search-previous-thread, > notmuch-search-next-thread, notmuch-tree-from-search-thread Fixes: 874f14ec ("emacs/tree: enable moving to next thread in search results") Reported-by: Danilo G. Baio Signed-off-by: William Casarin --- Hey there, "Danilo G. Baio" writes: > Hi William. > > I'm updating notmuch on FreeBSD (to 0.31) and I'm getting this issue: > > > ``` > [...] > =================================================== > ===> Staging for notmuch-emacs27-0.31 > ===> notmuch-emacs27-0.31 depends on executable: notmuch - found > ===> notmuch-emacs27-0.31 depends on file: /usr/local/bin/emacs-27.1 - found > ===> notmuch-emacs27-0.31 depends on executable: indexinfo - found > ===> Generating temporary packing list > gmake[1]: Entering directory '/wrkdirs/usr/ports/mail/notmuch-emacs/work-full/notmuch-0.31' > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-compat.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-version.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-lib.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-parser.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-tag.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-query.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/coolj.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-wash.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-company.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-address.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-maildir-fcc.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-draft.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-message.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-mua.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-crypto.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-print.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-show.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-hello.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-jump.el > /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-tree.el > > In end of data: > emacs/notmuch-tree.el:1143:1:Warning: the following functions are not known to > be defined: notmuch-search-previous-thread, notmuch-search-next-thread, > notmuch-tree-from-search-thread > > [...] > ``` > > I don't use Emacs and don't have a clue in how fix this. > > Could you help me? > > Regards. > -- > Danilo G. Baio (dbaio) I got this report from user with the new notmuch-tree updates. I didn't run into this, but it looks like these functions are supposed to be forwardly declared first? I don't have a way of testing this and I'm waiting to see if it fixes their issue, but thought I'd would post the patch here as well for review. Cheers, Will emacs/notmuch-tree.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index f342f85a..3336139e 100644 --- a/emacs/notmuch-tree.el +++ b/emacs/notmuch-tree.el @@ -41,6 +41,9 @@ (declare-function notmuch-read-query "notmuch" (prompt)) (declare-function notmuch-search-find-thread-id "notmuch" (&optional bare)) (declare-function notmuch-search-find-subject "notmuch" ()) +(declare-function notmuch-search-next-thread "notmuch" ()) +(declare-function notmuch-search-previous-thread "notmuch" ()) +(declare-function notmuch-tree-from-search-thread "notmuch" ()) ;; the following variable is defined in notmuch.el (defvar notmuch-search-query-string) -- 2.28.0