From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QBZ5NfyzLl9RAgAA0tVLHw (envelope-from ) for ; Sat, 08 Aug 2020 14:17:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EHpYMfyzLl+hJQAAB5/wlQ (envelope-from ) for ; Sat, 08 Aug 2020 14:17:32 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 632C1940223 for ; Sat, 8 Aug 2020 14:17:32 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 92F7E29AD7; Sat, 8 Aug 2020 10:17:13 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 4EB652711D for ; Sat, 8 Aug 2020 10:17:08 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 460C05FA66; Sat, 8 Aug 2020 10:17:08 -0400 (EDT) Received: (nullmailer pid 1124280 invoked by uid 1000); Sat, 08 Aug 2020 14:17:04 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 12/19] WIP: adding fallbacks for NULL config_path Date: Sat, 8 Aug 2020 11:16:46 -0300 Message-Id: <20200808141653.1124111-13-david@tethera.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200808141653.1124111-1-david@tethera.net> References: <20200808141653.1124111-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: MX4FOJ6PTY5QWCJ6P7O5UITHETHH77IN X-Message-ID-Hash: MX4FOJ6PTY5QWCJ6P7O5UITHETHH77IN X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.03 X-TUID: zg0vek93GD5D still need to test combinations of NULL and non-NULL arguments --- lib/open.cc | 95 ++++++++++++++++++++++++---- test/T590-libconfig.sh | 138 +++++++++++++++++++++++++++++++++++++---- 2 files changed, 209 insertions(+), 24 deletions(-) diff --git a/lib/open.cc b/lib/open.cc index 9b7da161..213dc21e 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -37,6 +37,82 @@ notmuch_database_open_verbose (const char *path, database, status_string); } +static const char * +_xdg_dir (void *ctx, + const char *xdg_root_variable, + const char *xdg_prefix, + const char *profile_name) +{ + const char *xdg_root = getenv (xdg_root_variable); + const char *home = getenv ("HOME"); + + if (! xdg_root) { + if (! home) return NULL; + + xdg_root = talloc_asprintf (ctx, + "%s/%s", + home, + xdg_prefix); + } + + if (! profile_name) + profile_name = getenv ("NOTMUCH_PROFILE"); + + if (! profile_name) + profile_name = "default"; + + return talloc_asprintf (ctx, + "%s/notmuch/%s", + xdg_root, + profile_name); +} + +static notmuch_status_t +_load_key_file (const char *path, + const char *profile, + GKeyFile **key_file) +{ + notmuch_status_t status = NOTMUCH_STATUS_SUCCESS; + void *local = talloc_new (NULL); + + if (path && EMPTY_STRING (path)) + goto DONE; + + if (! path) + path = getenv ("NOTMUCH_CONFIG"); + + if (! path) { + const char *dir = _xdg_dir (local, "XDG_CONFIG_HOME", ".config", profile); + + if (dir) { + path = talloc_asprintf (local, "%s/config", dir); + if (access (path, R_OK) !=0) + path = NULL; + } + } + + if (! path) { + const char *home = getenv ("HOME"); + + path = talloc_asprintf (local, "%s/.notmuch-config", home); + + if (! profile) + profile = getenv ("NOTMUCH_PROFILE"); + + if (profile) + path = talloc_asprintf (local, "%s.%s", path, profile); + } + + *key_file = g_key_file_new (); + if (! g_key_file_load_from_file (*key_file, path, G_KEY_FILE_NONE, NULL)) { + status = NOTMUCH_STATUS_FILE_ERROR; + } + +DONE: + talloc_free (local); + return status; +} + notmuch_status_t notmuch_database_open_with_config (const char *database_path, notmuch_database_mode_t mode, @@ -49,7 +125,6 @@ notmuch_database_open_with_config (const char *database_path, void *local = talloc_new (NULL); notmuch_database_t *notmuch = NULL; char *notmuch_path, *xapian_path, *incompat_features; - char *configured_database_path = NULL; char *message = NULL; struct stat st; int err; @@ -57,18 +132,14 @@ notmuch_database_open_with_config (const char *database_path, GKeyFile *key_file = NULL; static int initialized = 0; - /* XXX TODO: default locations for NULL case, handle profiles */ - if (config_path != NULL && ! EMPTY_STRING (config_path)) { - key_file = g_key_file_new (); - if (! g_key_file_load_from_file (key_file, config_path, G_KEY_FILE_NONE, NULL)) { - status = NOTMUCH_STATUS_FILE_ERROR; - goto DONE; - } - configured_database_path = g_key_file_get_value (key_file, "database", "path", NULL); + status = _load_key_file (config_path, profile, &key_file); + if (status) { + message = strdup ("Error: cannot load config file"); + goto DONE; } - - if (database_path == NULL) - database_path = configured_database_path; + + if (! database_path && key_file) + database_path = g_key_file_get_value (key_file, "database", "path", NULL); if (database_path == NULL) { message = strdup ("Error: Cannot open a database for a NULL path.\n"); diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh index a303319d..cc814efa 100755 --- a/test/T590-libconfig.sh +++ b/test/T590-libconfig.sh @@ -15,14 +15,21 @@ int main (int argc, char** argv) notmuch_database_t *db; char *val; notmuch_status_t stat; + char *msg = NULL; - EXPECT0(notmuch_database_open_with_config (argv[1], + for (int i=1; i c_tail @@ -51,7 +58,7 @@ test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "notmuch_database_get_config_list: empty list" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { notmuch_config_list_t *list; EXPECT0(notmuch_database_get_config_list (db, "nonexistent", &list)); @@ -83,7 +90,7 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "notmuch_database_get_config_list: all pairs" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { notmuch_config_list_t *list; EXPECT0(notmuch_database_set_config (db, "zzzafter", "afterval")); @@ -128,7 +135,7 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "notmuch_database_get_config_list: one prefix" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { notmuch_config_list_t *list; EXPECT0(notmuch_database_get_config_list (db, "test.key", &list)); @@ -147,7 +154,7 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "dump config" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { EXPECT0(notmuch_database_set_config (db, "key with spaces", "value, with, spaces!")); } @@ -165,7 +172,7 @@ test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "restore config" notmuch dump --include=config >EXPECTED -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { EXPECT0(notmuch_database_set_config (db, "test.key1", "mutatedvalue")); } @@ -175,7 +182,7 @@ notmuch dump --include=config >OUTPUT test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "notmuch_config_get" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); @@ -191,7 +198,7 @@ test_expect_equal_file EXPECTED OUTPUT backup_database test_begin_subtest "notmuch_config_set" -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} %NULL% { char *val; printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); @@ -221,8 +228,32 @@ restore_database backup_database test_begin_subtest "override config from file" +ovconfig=${TMP_DIRECTORY}/override-config +cp ${NOTMUCH_CONFIG} "${ovconfig}" +notmuch --config=${ovconfig} config set test.key1 overridden +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} "${ovconfig}" %NULL% +{ + printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); + EXPECT0(notmuch_database_get_config (db, "test.key1", &val)); + printf("test.key1 (db) = %s\n", val); + printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); +} +EOF +cat <<'EOF' >EXPECTED +== stdout == +test.key1 = overridden +test.key1 (db) = testvalue1 +test.key2 = testvalue2 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT +restore_database + +backup_database +test_begin_subtest "override config from \${NOTMUCH_CONFIG}" notmuch config set test.key1 overridden -cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} +# second argument omitted to make argv[2] == NULL +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} { printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); EXPECT0(notmuch_database_get_config (db, "test.key1", &val)); @@ -230,6 +261,7 @@ cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} ${NOTMUCH_CONFIG} printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); } EOF +notmuch config set test.key1 cat <<'EOF' >EXPECTED == stdout == test.key1 = overridden @@ -240,4 +272,86 @@ EOF test_expect_equal_file EXPECTED OUTPUT restore_database +backup_database +test_begin_subtest "override config from \${HOME}/.notmuch-config" +ovconfig=${HOME}/.notmuch-config +cp ${NOTMUCH_CONFIG} ${ovconfig} +old_NOTMUCH_CONFIG=${NOTMUCH_CONFIG} +unset NOTMUCH_CONFIG +notmuch --config=${ovconfig} config set test.key1 overridden-home +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} %NULL% %NULL% +{ + printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); + EXPECT0(notmuch_database_get_config (db, "test.key1", &val)); + printf("test.key1 (db) = %s\n", val); + printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); +} +EOF +rm -f ${ovconfig} +NOTMUCH_CONFIG=${old_NOTMUCH_CONFIG} +cat <<'EOF' >EXPECTED +== stdout == +test.key1 = overridden-home +test.key1 (db) = testvalue1 +test.key2 = testvalue2 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT +restore_database + +backup_database +test_begin_subtest "override config from \${XDG_CONFIG_HOME}/notmuch" +ovconfig=${HOME}/.config/notmuch/default/config +mkdir -p $(dirname ${ovconfig}) +cp ${NOTMUCH_CONFIG} ${ovconfig} +old_NOTMUCH_CONFIG=${NOTMUCH_CONFIG} +unset NOTMUCH_CONFIG +notmuch --config=${ovconfig} config set test.key1 overridden-home +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} %NULL% %NULL% +{ + printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); + EXPECT0(notmuch_database_get_config (db, "test.key1", &val)); + printf("test.key1 (db) = %s\n", val); + printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); +} +EOF +rm -f ${ovconfig} +NOTMUCH_CONFIG=${old_NOTMUCH_CONFIG} +cat <<'EOF' >EXPECTED +== stdout == +test.key1 = overridden-home +test.key1 (db) = testvalue1 +test.key2 = testvalue2 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT +restore_database + +backup_database +test_begin_subtest "override config from \${HOME}/.notmuch-config.work (via args)" +ovconfig=${HOME}/.notmuch-config.work +cp ${NOTMUCH_CONFIG} ${ovconfig} +old_NOTMUCH_CONFIG=${NOTMUCH_CONFIG} +unset NOTMUCH_CONFIG +notmuch --config=${ovconfig} config set test.key1 overridden-home +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} %NULL% work +{ + printf("test.key1 = %s\n", notmuch_config_get (db, "test.key1")); + EXPECT0(notmuch_database_get_config (db, "test.key1", &val)); + printf("test.key1 (db) = %s\n", val); + printf("test.key2 = %s\n", notmuch_config_get (db, "test.key2")); +} +EOF +#rm -f ${ovconfig} +NOTMUCH_CONFIG=${old_NOTMUCH_CONFIG} +cat <<'EOF' >EXPECTED +== stdout == +test.key1 = overridden-home +test.key1 (db) = testvalue1 +test.key2 = testvalue2 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT +restore_database + test_done -- 2.28.0