unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 13/14] test: regression test for traversing config list with closed db
Date: Sat,  1 Aug 2020 09:26:02 -0300	[thread overview]
Message-ID: <20200801122603.285803-14-david@tethera.net> (raw)
In-Reply-To: <20200801122603.285803-1-david@tethera.net>

Also mention error return in API docs
---
 lib/notmuch.h          |  1 +
 test/T590-libconfig.sh | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/lib/notmuch.h b/lib/notmuch.h
index 9a2a3b1f..f3cb0fe2 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -2291,6 +2291,7 @@ notmuch_config_list_key (notmuch_config_list_t *config_list);
  * next call to notmuch_config_list_value or notmuch config_list_destroy
  *
  * @since libnotmuch 4.4 (notmuch 0.23)
+ * @retval NULL for errors
  */
 const char *
 notmuch_config_list_value (notmuch_config_list_t *config_list);
diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh
index 602fad0b..360e45b0 100755
--- a/test/T590-libconfig.sh
+++ b/test/T590-libconfig.sh
@@ -100,6 +100,28 @@ zzzafter afterval
 EOF
 test_expect_equal_file EXPECTED OUTPUT
 
+test_begin_subtest "notmuch_database_get_config_list: all pairs (closed db)"
+cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR}
+{
+   notmuch_config_list_t *list;
+   EXPECT0(notmuch_database_get_config_list (db, "", &list));
+   EXPECT0(notmuch_database_close (db));
+   for (; notmuch_config_list_valid (list); notmuch_config_list_move_to_next (list)) {
+      printf("%s %d\n", notmuch_config_list_key (list), NULL == notmuch_config_list_value(list));
+   }
+   notmuch_config_list_destroy (list);
+}
+EOF
+cat <<'EOF' >EXPECTED
+== stdout ==
+aaabefore 1
+testkey1 1
+testkey2 1
+zzzafter 1
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
 test_begin_subtest "notmuch_database_get_config_list: one prefix"
 cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR}
 {
-- 
2.27.0

  parent reply	other threads:[~2020-08-01 12:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01 12:25 Final (v2) batch of patches in API exception handling cleanup David Bremner
2020-08-01 12:25 ` [PATCH 01/14] lib: return NULL from n_d_get_default_indexopts on error David Bremner
2020-08-01 12:25 ` [PATCH 02/14] test: add regression test for n_messages_collect_tags David Bremner
2020-08-01 12:25 ` [PATCH 03/14] test: split header for lib-message tests David Bremner
2020-08-01 12:25 ` [PATCH 04/14] test: regression test for n_m_get_filenames David Bremner
2020-08-01 12:25 ` [PATCH 05/14] test: add known broken test for n_directory_get_child_directories David Bremner
2020-08-01 12:25 ` [PATCH 06/14] lib: catch exceptions in n_directory_get_child_directories David Bremner
2020-08-01 12:25 ` [PATCH 07/14] test: add known broken test for n_directory_get_child_files David Bremner
2020-08-01 12:25 ` [PATCH 08/14] lib: catch exceptions in n_directory_get_child_files David Bremner
2020-08-01 12:25 ` [PATCH 09/14] test: known broken test for n_directory_delete with closed db David Bremner
2020-08-01 12:25 ` [PATCH 10/14] lib: fix return value for n_directory_delete David Bremner
2020-08-01 12:26 ` [PATCH 11/14] test: regression test for n_directory_{get,set}_mtime David Bremner
2020-08-01 12:26 ` [PATCH 12/14] test: regression test for n_d_get_config_list on closed db David Bremner
2020-08-01 12:26 ` David Bremner [this message]
2020-08-01 12:26 ` [PATCH 14/14] test: regression tests for n_indexopts_{get,set}_decrypt_policy David Bremner
2020-08-04  1:38 ` Final (v2) batch of patches in API exception handling cleanup David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801122603.285803-14-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).