unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Greg Anders <greg@gpanders.com>
To: Stefano Zacchiroli <zack@debian.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [Kevin McCarthy] Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name
Date: Sun, 26 Jul 2020 15:10:59 -0600	[thread overview]
Message-ID: <20200726211059.GA91635@Kepler> (raw)
In-Reply-To: <20200723104538.s474yxb53tx47peu@upsilon.cc>

 From 92221d856e663450c1f55b9ec9a6aa69b4d27b3d Mon Sep 17 00:00:00 2001
From: Greg Anders <pub@gpanders.com>
Date: Sun, 26 Jul 2020 14:57:56 -0600
Subject: [PATCH] notmuch-mutt: quote variables to prevent word splitting

This fixes a bug where mail under directories with spaces in their names
would not be found.
---
  contrib/notmuch-mutt/notmuch-mutt | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
index d33223bd..8ab1849f 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -50,7 +50,7 @@ sub search($$$) {
      empty_maildir($maildir);
      system("notmuch search --output=files $dup_option $query"
  	   . " | sed -e 's: :\\\\ :g'"
-	   . " | while IFS= read -r searchoutput; do ln -s \$searchoutput $maildir/cur/; done");
+	   . " | while IFS= read -r searchoutput; do ln -s \"\$searchoutput\" $maildir/cur/; done");
  }
  
  sub prompt($$) {
-- 
2.27.0

  reply	other threads:[~2021-07-30 11:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <159546998738.232977.10166967333633103899.reportbug@afu.lan>
2020-07-23  9:50 ` [Kevin McCarthy] Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name David Bremner
2020-07-23 10:45   ` Stefano Zacchiroli
2020-07-26 21:10     ` Greg Anders [this message]
2020-08-01 23:22       ` David Bremner
2020-08-02 14:39         ` Greg Anders
2020-07-23 15:58   ` Tomi Ollila
2020-07-24 18:38     ` Kevin J. McCarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200726211059.GA91635@Kepler \
    --to=greg@gpanders.com \
    --cc=notmuch@notmuchmail.org \
    --cc=zack@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).