From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EMo/LFK2HV9YGgAA0tVLHw (envelope-from ) for ; Sun, 26 Jul 2020 16:58:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uC4ZKFK2HV/QMwAAB5/wlQ (envelope-from ) for ; Sun, 26 Jul 2020 16:58:58 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2963E9404CF for ; Sun, 26 Jul 2020 16:58:58 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 639A627BDC; Sun, 26 Jul 2020 12:58:34 -0400 (EDT) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 8988620233 for ; Sun, 26 Jul 2020 12:58:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E1532160F4 for ; Sun, 26 Jul 2020 18:58:18 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id qhz3xWoN9Djn for ; Sun, 26 Jul 2020 18:58:18 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B0763160BA for ; Sun, 26 Jul 2020 18:58:18 +0200 (CEST) From: Jonas Bernoulli To: notmuch@notmuchmail.org Subject: [PATCH 00/23] A create number of cosmetic changes Date: Sun, 26 Jul 2020 18:57:55 +0200 Message-Id: <20200726165818.400-1-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Message-ID-Hash: B7TX5TGNHRCCRT3O4WMHVFITSR4O4P4U X-Message-ID-Hash: B7TX5TGNHRCCRT3O4WMHVFITSR4O4P4U X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.03 X-TUID: AOYjpdkDDlb3 Hello, Please forgive me for this wall of unsolicited cleanup; I blame it on a mild form of ocd. I made most of these changes a few months ago when I was splitting the libraries into `outline-minor-mode' compatible sections. To do so I had to have some understanding of the code I was splitting up and that closer look led to me discovering issues and once I had ran into a bunch of issue of the same kind it made sense to systematically look for that kind across all elisp files. Well, one thing led to another and here we are with 23 cleanup commits, some of which are fairly big on their own. I just looked at very change again; everything looks to be in order. I am intentionally leaving out that one commit that actually does what I originally set out to do. In some cases I will need to gain a deeper understanding before I can finish splitting libraries into sections. Cheers, Jonas Jonas Bernoulli (23): emacs: Shorten long lines emacs: Remove excess empty lines emacs: Fix indentation emacs: Closing parenthesis go on the same line emacs: Only set one variable per setq form emacs: Use cl-incf where appropriate emacs: Use 'and' instead of 'when' when the return value matters emacs: Use 'unless' instead of 'when' and 'not' emacs: Use 'when' instead of 'if' when there is no ELSE part emacs: Use one or three lines for 'if' forms emacs: Extend face to window edge again emacs: Fix some function declarations emacs: No longer define notmuch-hello-mode-map as a function emacs: notmuch-poll: Let the user know we are polling emacs: Use makefile-gmake-mode in Makefile*s emacs: Improve doc-strings emacs: Autoload notmuch-jump-search only once emacs: Autoload notmuch-jump using an autoload cookie emacs: Various cosmetic changes emacs: Increase consistency of library headers Fix typos .dir-locals.el: Set variables for correct "shell" mode test: Fix indentation .dir-locals.el | 2 +- Makefile.global | 1 + Makefile.local | 2 +- NEWS | 2 +- bindings/Makefile.local | 2 +- bindings/python-cffi/notmuch2/__init__.py | 2 +- bindings/python-cffi/notmuch2/_base.py | 6 +- bindings/python-cffi/notmuch2/_database.py | 8 +- bindings/python-cffi/notmuch2/_message.py | 4 +- bindings/python-cffi/notmuch2/_tags.py | 8 +- bindings/python-cffi/tests/conftest.py | 2 +- bindings/python/notmuch/database.py | 12 +- bindings/python/notmuch/query.py | 2 +- compat/Makefile.local | 2 +- completion/Makefile.local | 2 +- doc/Makefile.local | 2 +- emacs/Makefile.local | 2 +- emacs/coolj.el | 24 +- emacs/make-deps.el | 5 +- emacs/notmuch-address.el | 186 ++++----- emacs/notmuch-company.el | 53 ++- emacs/notmuch-compat.el | 99 +++-- emacs/notmuch-crypto.el | 49 ++- emacs/notmuch-draft.el | 24 +- emacs/notmuch-hello.el | 102 +++-- emacs/notmuch-jump.el | 61 ++- emacs/notmuch-lib.el | 204 +++++----- emacs/notmuch-maildir-fcc.el | 122 +++--- emacs/notmuch-message.el | 3 +- emacs/notmuch-mua.el | 181 ++++----- emacs/notmuch-parser.el | 16 +- emacs/notmuch-print.el | 2 +- emacs/notmuch-query.el | 29 +- emacs/notmuch-show.el | 439 ++++++++++----------- emacs/notmuch-tag.el | 38 +- emacs/notmuch-tree.el | 189 ++++----- emacs/notmuch-wash.el | 109 +++-- emacs/notmuch.el | 276 ++++++------- emacs/rstdoc.el | 18 +- lib/Makefile.local | 2 +- lib/notmuch.h | 4 +- parse-time-string/Makefile.local | 2 + performance-test/Makefile.local | 2 +- tag-util.c | 2 +- tag-util.h | 2 +- test/Makefile.local | 2 +- test/T610-message-property.sh | 2 +- test/T710-message-id.sh | 2 +- test/emacs-address-cleaning.el | 2 +- test/random-corpus.c | 2 +- test/test-lib.el | 47 ++- test/test-lib.sh | 36 +- util/Makefile.local | 2 +- 53 files changed, 1189 insertions(+), 1210 deletions(-) -- 2.26.0