unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: [PATCH 08/13] test: regression test for n_directory_delete with closed db.
Date: Sun, 26 Jul 2020 08:59:26 -0300	[thread overview]
Message-ID: <20200726115931.1448056-9-david@tethera.net> (raw)
In-Reply-To: <20200726115931.1448056-1-david@tethera.net>

To the best of my current understanding, it's a bug in Xapian that no
exception is thrown here. The test should pass in either case.
---
 test/T563-lib-directory.sh | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/test/T563-lib-directory.sh b/test/T563-lib-directory.sh
index 739469a6..4de31078 100755
--- a/test/T563-lib-directory.sh
+++ b/test/T563-lib-directory.sh
@@ -26,7 +26,7 @@ int main (int argc, char** argv)
      exit (1);
    }
 
-   EXPECT0(notmuch_database_get_directory (db, "", &dir));
+   EXPECT0(notmuch_database_get_directory (db, "bar", &dir));
    EXPECT0(notmuch_database_close (db));
 EOF
 
@@ -74,4 +74,21 @@ A Xapian exception occurred at lib/directory.cc:XXX: Database has been closed
 EOF
 test_expect_equal_file EXPECTED OUTPUT
 
+backup_database
+test_begin_subtest "delete directory document for a closed db"
+cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR}
+    {
+        stat = notmuch_directory_delete (dir);
+        printf ("%d\n", stat == NOTMUCH_STATUS_SUCCESS || stat == NOTMUCH_STATUS_XAPIAN_EXCEPTION);
+        stat = NOTMUCH_STATUS_SUCCESS;
+    }
+EOF
+cat <<EOF > EXPECTED
+== stdout ==
+1
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+restore_database
+
 test_done
-- 
2.27.0

  parent reply	other threads:[~2020-07-26 12:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26 11:59 final(?) batch of api cleanup for exception handling David Bremner
2020-07-26 11:59 ` [PATCH 01/13] test: add regression test for n_messages_collect_tags David Bremner
2020-07-26 11:59 ` [PATCH 02/13] test: split header for lib-message tests David Bremner
2020-07-26 11:59 ` [PATCH 03/13] test: regression test for n_m_get_filenames David Bremner
2020-07-26 11:59 ` [PATCH 04/13] test: add known broken test for n_directory_get_child_directories David Bremner
2020-07-26 11:59 ` [PATCH 05/13] lib: catch exceptions in n_directory_get_child_directories David Bremner
2020-07-26 11:59 ` [PATCH 06/13] test: add known broken test for n_directory_get_child_files David Bremner
2020-07-26 11:59 ` [PATCH 07/13] lib: catch exceptions in n_directory_get_child_files David Bremner
2020-07-26 11:59 ` David Bremner [this message]
2020-07-27  0:55   ` [PATCH 1/2] test: known broken test for n_directory_delete with closed db David Bremner
2020-07-27  0:55     ` [PATCH 2/2] lib: fix return value for n_directory_delete David Bremner
2020-07-27 12:06   ` [PATCH 08/13] test: regression test for n_directory_delete with closed db David Bremner
2020-07-26 11:59 ` [PATCH 09/13] test: regression test for n_directory_{get,set}_mtime David Bremner
2020-07-26 11:59 ` [PATCH 10/13] test: regression test for n_d_get_config_list on closed db David Bremner
2020-07-26 11:59 ` [PATCH 11/13] test: regression test for traversing config list with " David Bremner
2020-07-26 11:59 ` [PATCH 12/13] test: regression tests for n_indexopts_{get,set}_decrypt_policy David Bremner
2020-07-26 11:59 ` [PATCH 13/13] lib: return NULL from n_d_get_default_indexopts on error David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200726115931.1448056-9-david@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).