From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KOXXOHIQE18GHwAA0tVLHw (envelope-from ) for ; Sat, 18 Jul 2020 15:08:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +CaTNHIQE19ePQAAbx9fmQ (envelope-from ) for ; Sat, 18 Jul 2020 15:08:34 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A397B940509 for ; Sat, 18 Jul 2020 15:08:34 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3A16C26BAC; Sat, 18 Jul 2020 11:08:15 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 29F671FC8D for ; Sat, 18 Jul 2020 11:08:04 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 21507609DB; Sat, 18 Jul 2020 11:08:04 -0400 (EDT) Received: (nullmailer pid 4106234 invoked by uid 1000); Sat, 18 Jul 2020 15:07:56 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 05/10] test: regression test for n_d_upgrade Date: Sat, 18 Jul 2020 12:07:46 -0300 Message-Id: <20200718150751.4106125-6-david@tethera.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200718150751.4106125-1-david@tethera.net> References: <20200718150751.4106125-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 63ZXO64LZPXAF56NSIA5TAJJSQTV5YOI X-Message-ID-Hash: 63ZXO64LZPXAF56NSIA5TAJJSQTV5YOI X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 1.53 X-TUID: l1oNaZ8SnOaK The logic is that if it's acceptable to return SUCCESS for read only database, it's acceptable for a closed one. --- test/T562-lib-database.sh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index 4bcbc805..d975f109 100755 --- a/test/T562-lib-database.sh +++ b/test/T562-lib-database.sh @@ -146,4 +146,21 @@ cat < EXPECTED EOF test_expect_equal_file EXPECTED OUTPUT +test_begin_subtest "upgrade a closed db" +cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} + { + notmuch_bool_t ret; + + EXPECT0(notmuch_database_close (db)); + stat = notmuch_database_upgrade (db, NULL, NULL); + printf ("%d\n", ret == NOTMUCH_STATUS_SUCCESS); + } +EOF +cat < EXPECTED +== stdout == +1 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT + test_done -- 2.27.0