From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IJnjIQzPAV8BNAAA0tVLHw (envelope-from ) for ; Sun, 05 Jul 2020 13:01:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gFKcHQzPAV+GbAAAbx9fmQ (envelope-from ) for ; Sun, 05 Jul 2020 13:01:00 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0B8F94066C for ; Sun, 5 Jul 2020 13:00:59 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DBA141FC4C; Sun, 5 Jul 2020 09:00:54 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8BE0B1FC39 for ; Sun, 5 Jul 2020 09:00:52 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 80456613B0; Sun, 5 Jul 2020 09:00:52 -0400 (EDT) Received: (nullmailer pid 4057411 invoked by uid 1000); Sun, 05 Jul 2020 13:00:51 -0000 From: David Bremner To: notmuch@notmuchmail.org Cc: David Bremner Subject: [PATCH 01/11] lib: add regression test for n_m_get_date; clarify API Date: Sun, 5 Jul 2020 10:00:16 -0300 Message-Id: <20200705130025.4057292-2-david@tethera.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200705130025.4057292-1-david@tethera.net> References: <20200705130025.4057292-1-david@tethera.net> MIME-Version: 1.0 Message-ID-Hash: L6H345TG76QH6T5APWZJ6BYOKDWR56IC X-Message-ID-Hash: L6H345TG76QH6T5APWZJ6BYOKDWR56IC X-MailFrom: bremner@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 1.53 X-TUID: LVblVQVYQ6fL This function catches Xapian exceptions. The test is intended to make sure it stays that way. --- lib/notmuch.h | 2 ++ test/T560-lib-error.sh | 16 ++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/lib/notmuch.h b/lib/notmuch.h index c7b21060..b7de7652 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -1528,6 +1528,8 @@ notmuch_message_set_flag (notmuch_message_t *message, * For the original textual representation of the Date header from the * message call notmuch_message_get_header() with a header value of * "date". + * + * Returns 0 in case of error. */ time_t notmuch_message_get_date (notmuch_message_t *message); diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh index 06b43ef2..ab7a24d1 100755 --- a/test/T560-lib-error.sh +++ b/test/T560-lib-error.sh @@ -470,5 +470,21 @@ cat < EXPECTED EOF test_expect_equal_file EXPECTED OUTPUT +test_begin_subtest "Handle getting date from closed database" +cat c_head2 - c_tail <<'EOF' | test_C ${MAIL_DIR} + { + time_t result; + result = notmuch_message_get_date (message); + printf("%d\n%d\n", message != NULL, result == 0); + } +EOF +cat < EXPECTED +== stdout == +1 +1 +== stderr == +EOF +test_expect_equal_file EXPECTED OUTPUT + test_done -- 2.27.0