From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: introduce exception handling at top level of libnotmuch
Date: Mon, 29 Jun 2020 22:14:07 -0300 [thread overview]
Message-ID: <20200630011411.612552-1-david@tethera.net> (raw)
I know that some of you are not C++ fans, but at the moment this is
the cleanest fix I can think of to uncaught xapian exceptions causing
calls to the library to die. Floris reminded me of this recently with
the discussion about operations on closed databases, but cleaning up
the handling of exceptions in libnotmuch has been on my mind for a
while. It will be bit laborious so I did a few functions for
discussion purposes before getting too carried away.
There is still a certain amount of boilerplate with more or less
identical try/catch blocks (yes, I really miss scheme macros here). I
could mostly eliminate that with C++11 lambdas, but I wasn't sure the
result was more maintainable or nicer.
This is definitely targeted for post 0.30.
next reply other threads:[~2020-06-30 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 1:14 David Bremner [this message]
2020-06-30 1:14 ` [PATCH 1/4] test: add known broken test for error handling on closed database David Bremner
2020-06-30 1:14 ` [PATCH 2/4] lib: catch error from closed db in n_m_get_message_id David Bremner
2020-07-04 15:44 ` Floris Bruynooghe
2020-07-04 17:17 ` David Bremner
2020-07-05 11:17 ` David Bremner
2020-07-08 19:55 ` Floris Bruynooghe
2020-07-08 19:52 ` Floris Bruynooghe
2020-06-30 1:14 ` [PATCH 3/4] test: add known broken test for n_m_get_thread_id on closed db David Bremner
2020-06-30 1:14 ` [PATCH 4/4] lib/message: catch exception in n_m_get_thread_id David Bremner
2020-07-02 19:16 ` introduce exception handling at top level of libnotmuch Daniel Kahn Gillmor
2020-07-04 0:15 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630011411.612552-1-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).