From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cBbTCn6z814oSQAA0tVLHw (envelope-from ) for ; Wed, 24 Jun 2020 20:11:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kLueBn6z814PfgAAB5/wlQ (envelope-from ) for ; Wed, 24 Jun 2020 20:11:42 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FD879402D1 for ; Wed, 24 Jun 2020 20:11:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 66CFD6DE1455; Wed, 24 Jun 2020 13:11:34 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 08i9u3mUeGuH; Wed, 24 Jun 2020 13:11:33 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 4F0CF6DE1444; Wed, 24 Jun 2020 13:11:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 580BB6DE1444 for ; Wed, 24 Jun 2020 13:11:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SaAiYxmO0CmU for ; Wed, 24 Jun 2020 13:11:29 -0700 (PDT) Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) by arlo.cworth.org (Postfix) with ESMTPS id 7E18F6DE1435 for ; Wed, 24 Jun 2020 13:11:28 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by meesny.iki.fi (Postfix) with ESMTPSA id 4A33820577; Wed, 24 Jun 2020 23:11:24 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1593029484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=6f/+gQiscPH9mi99f043FoqyJjVoc3eDW0XKcOdNM3A=; b=gB8CDl9plufX9tl+Yo9+hQLrwuHcA6AEeTh8Yeq4nnyfDyxf3SAhp0mI3P3hJ5U0r6g8ld 8ra2IAIa6XTs7sefMsoHDR8rBX/yiFuOxdhf73Doj+Zf4RA5kwBJcyxI/UFnzrxpKdz0aG SBftmKI3vv7Lv1/giB6LstJlSA04l0M= From: Tomi Ollila To: notmuch@notmuchmail.org Subject: [PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required Date: Wed, 24 Jun 2020 23:11:20 +0300 Message-Id: <20200624201120.31049-1-tomi.ollila@iki.fi> X-Mailer: git-send-email 2.13.3 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1593029484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=6f/+gQiscPH9mi99f043FoqyJjVoc3eDW0XKcOdNM3A=; b=qdEelcoSpDHbU02/wflyXzNi+MzBsdRcaT58A5Sx1njQt0yZk+m6bsGsFrn+Rx3QfiQ+4Z 6pfOgHmiolj+vWpePw8rrzyJ5Oe+I2ZybAVGFyhiE9iVLoUAb9Sfi4M/kQPc7s6pw1zZCw /KEhsM5h1jKCBDZZBnWJMDOglQqkeSY= ARC-Seal: i=1; s=meesny; d=iki.fi; t=1593029484; a=rsa-sha256; cv=none; b=KZcnZPkdOegZ30w2ieqDrpMiKoMACgOGFEasojsxdTNWy8aTYZGqk1vZ6hRUJIsa8mT87p wMGUzoAn38VmvDIY/7cv5PP6tgto2pcsgMYrosWr4kLk0s4nRw3kGcXOIs8I9hJIgiANLi hZ+5pIK4M7rTx7Mao4vTtiY6tsjtiic= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tomi.ollila@iki.fi MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=meesny header.b=gB8CDl9p; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 2.99 X-TUID: +CiJFH39lefx Since October 2018 building notmuch has actually required compiler that knows C11. Also this -std=gnu99 was not used in code compiled by configure, so in theory this could have caused problems... ...but no related reports have been sent, perhaps ever. Both gcc and clang has been shipping compilers supporting C11 (or later) by default for more than four years now. Therefore, just dropping -std=gnu99 (and not checking C11 compatibility for now, for simplicity) is easiest to do, and removes inconsistency between configure and build time compilations. --- Makefile.global | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.global b/Makefile.global index 0aee5876..98b6962e 100644 --- a/Makefile.global +++ b/Makefile.global @@ -49,8 +49,7 @@ DETACHED_SIG_FILE=$(TAR_FILE).asc PV_FILE=bindings/python/notmuch/version.py # Smash together user's values with our extra values -STD_CFLAGS := -std=gnu99 -FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(STD_CFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS) +FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS) FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS) FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lnotmuch_util -Llib -lnotmuch ifeq ($(LIBDIR_IN_LDCONFIG),0) -- 2.25.1