unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH] configure: require python 3.5 for CFFI-based notmuch bindings
Date: Sat,  6 Jun 2020 00:57:55 +0300	[thread overview]
Message-ID: <20200605215755.25305-1-tomi.ollila@iki.fi> (raw)

Also tell users what the consequences of a "No" answer is when
python version is less than 3.5, cffi or setuptools is missing,
or no pytest >= 3.0 is available.
---
 configure | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index e4c738e5..f4b3c61a 100755
--- a/configure
+++ b/configure
@@ -713,14 +713,14 @@ fi
 
 have_python3_dev=0
 if [ $have_python -eq 1 ]; then
-    printf "Checking for python3 dev..."
+    printf "Checking for python3 dev (>= 3.5)..."
     if "$python" -c 'import os, sys, sysconfig;
-assert sys.version_info >= (3,0)
+assert sys.version_info >= (3,5)
 assert os.path.isfile(sysconfig.get_config_h_filename())' >/dev/null 2>&1; then
         printf "Yes.\n"
         have_python3_dev=1
     else
-        printf "No.\n"
+        printf "No (will not install CFFI-based python bindings).\n"
     fi
 fi
 
@@ -732,7 +732,7 @@ if [ $have_python3_dev -eq 1 ]; then
         printf "Yes.\n"
         have_python3_cffi=1
     else
-        printf "No.\n"
+        printf "No (will not install CFFI-based python bindings).\n"
     fi
 
     printf "Checking for python3 pytest (>= 3.0)... "
@@ -742,7 +742,7 @@ if [ $have_python3_dev -eq 1 ]; then
         printf "Yes.\n"
         have_python3_pytest=1
     else
-        printf "No.\n"
+        printf "No (will not test CFFI-based python bindings).\n"
     fi
     rm -f $conf
 fi
-- 
2.26.2

             reply	other threads:[~2020-06-05 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 21:57 Tomi Ollila [this message]
2020-06-06 11:47 ` [PATCH] configure: require python 3.5 for CFFI-based notmuch bindings David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605215755.25305-1-tomi.ollila@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).